[Pkg-javascript-devel] Bug#980291: Bug#980294: libjs-jquery-flot: breaking API change

[Antonio Terceiro]

Hi,

On Sun, Jan 17, 2021 at 12:03:54PM -0300, Antonio Terceiro wrote:
[...]
> After a bit of investigation, this looks more like a larger change in
> API of the package. In the previous version:
> 
> - the main jquery.flot.js does *not* include the plugins
> - minified versions of the plugins are provided
> 
> In the new version:
> 
> - the main jquery.flot.js *does* include the plugins
> - minified versions of the plugins are not provided
> 
> Because the main file did not include the plugins, debci includes
> jquery.flot.min.js, jquery.flot.time.min.js, and
> jquery.flot.stack.min.js.
> 
> With the new version I can achieve the same effect by including only
> jquery.flot.js. Not only that, if I also include the plugins explicitly,
> then the charts break in strange ways.
> 
> This new version can will most probably break charts in existing
> applications in unpredictable ways. The are the following reverse
> dependencies:
> 
> * anki
> * appstream-generator [amd64 arm64 i386]
> * debci
> * flightgear-phi
> * ganglia-webfrontend
> * gitinspector
> * lava-dev
> * lava-server
> * python3-gavo
> * python3-pympler
> * ruby-flot-rails
> * spip
> 
> This new version will require source changes in several packages, and
> this is a transition started too late in the release cycle.

Thanks for your updates. However, they didn't address the fact that
reverse dependencies will now require source changes to packages that
use flot.

For example these are the changes that I need to do in debci to make it
work:

https://salsa.debian.org/terceiro/debci/-/commit/b02224c327ccf74daeca48b89033ba4f413a3060

In special, I need to stop including the standalone plugin files,
because it's already included in the main file. This wasn't the case in
the previous version, and I get that this is how upstream designed it to
be.

But the fact is that all the other reverse dependencies that used any
plugin now need to be changed accordingly. Otherwise we can just wait
for their chart features to break in subtle ways in the face of users.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20210118/04ace36d/attachment.sig>