[Pkg-javascript-devel] Bug#980406: Bug#980406: Bug#980406: This is confirmed as a bug in debian package

[Pirate Praveen]

On Tue, Jan 19, 2021 at 5:06 pm, Xavier <yadd at debian.org> wrote:
> Le 19/01/2021 à 15:04, Pirate Praveen a écrit :
>> 
>> 
>>  On Tue, Jan 19, 2021 at 2:24 pm, Pirate Praveen
>>  <praveen at onenetbeyond.org> wrote:
>>>  Control: severity -1 serious
>>> 
>>>  I was able to use xterm 3.8.1 from nmpjs.com with gitlab without 
>>> any
>>>  issues. So this is a bug in node-xterm debian build.
>> 
>>  Trying to switch to rollup instead of browserify-lite, but tsc 
>> itself is
>>  failing now.
> 
> --- a/src/Terminal.ts
> +++ b/src/Terminal.ts
> @@ -1636,7 +1636,9 @@
>     */
>    public log(text: string, data?: any): void {
>      if (!this.options.debug) return;
> +    // @ts-ignore
>      if (!this._context.console || !this._context.console.log) return;
> +    // @ts-ignore
>      this._context.console.log(text, data);
>    }
> 
> @@ -1645,7 +1647,9 @@
>     */
>    public error(text: string, data?: any): void {
>      if (!this.options.debug) return;
> +    // @ts-ignore
>      if (!this._context.console || !this._context.console.error) 
> return;
> +    // @ts-ignore
>      this._context.console.error(text, data);
>    }
> 
> --- a/src/renderer/ColorManager.test.ts
> +++ b/src/renderer/ColorManager.test.ts
> @@ -15,6 +15,7 @@
> 
>    beforeEach(() => {
>      dom = new jsdom.JSDOM('');
> +    // @ts-ignore
>      window = dom.window;
>      document = window.document;
>      (<any>window).HTMLCanvasElement.prototype.getContext = () => ({

I don't really understand this part. Can you fix this?

thanks
Praveen