[Pkg-javascript-devel] Bug#940704: Bug#940704: next error

[Paolo Greppi]

Dear Xavier,

Il 27/01/21 06:30, Xavier ha scritto:
> Le 27/01/2021 à 00:14, Paolo Greppi a écrit :
>> I fixed the error:
>>
>>      Cannot find module 'babel-preset-env'
>>
>> but I am not sure if the fix is 100% right.
>>
>> Now I get:
>>
>>      TypeError: Cannot read property 'mkdir' of undefined
>>             5 | export default function(filename?: string):
>> Promise<string> {
>>             6 |   return new Promise((resolve, reject) => {
>>          >  7 |     temp.mkdir(filename, function(err, path) {
>>
>> I added node-temp in debian/tests/control Depends afetr jest, but that
>> did not help (it would have errored on require('temp') anyway).
>>
>> I have then turned my attention at brushing up node-temp, see this
>> message to the js-team list:
>> https://alioth-lists.debian.net/pipermail/pkg-javascript-devel/2021-January/052152.html
> 
> Hi,
> 
> fixed (patch for node-mkdirp ≥ 1), take a look at my changes
> 

Fantastic job thanks!
I suggest that you also upload it - I am still a DM so I'd nee to bother someone for sponsorship anyway.

The only comment I have is that the Salsa CI was already enabled, as I had set the Custom CI config path to recipes/debian.yml at salsa-ci-team/pipeline in Settings -> CI/CD -> General Pipelines as advised "If the base pipeline configuration fits your needs without further modifications" here:
https://salsa.debian.org/salsa-ci-team/pipeline#basic-use

But now you have set it to debian/salsa-ci.yml and added that file, with the same content as:
https://salsa.debian.org/salsa-ci-team/pipeline/-/blob/master/recipes/debian.yml
so nothing changes.

Is there any reason why you prefer the debian/salsa-ci.yml way ?

Paolo