[Pkg-javascript-devel] Bug#990550: [Pre-Approval] unblock: node-babel-plugin-add-module-exports/1.0.4+dfsg1~cs5.8.0-2

[Pirate Praveen]

Package: release.debian.org
Severity: normal
User: release.debian.org at packages.debian.org
Usertags: unblock
X-DebBugs-CC: pkg-javascript-devel at alioth-lists.debian.net

I'd like to check if we can unblock package 
node-babel-plugin-add-module-exports (currently in experimental) with 
its reverse build dependencies.

[ Reason ]
The current version in bullseye created broken output (worked fine in 
buster). This regression was introduced by babel 7 transition but 
noticed only recently while testing diaspora. See #990493 #990458 for 
details. The current version is very outdated and moving to the latest 
upsteam release makes better sense for long term maintenance. Also 
upstream made changes in build system and rewrote the code in ES6 
(moved to babel) so backporting is not really worth the long term 
maintenance effort.

[ Impact ]

These packages are currently broken in bullseye and will also need to 
be rebuilt and uploaded (arch all, so no binNMU),

* autosize.js
* node-babel-plugin-lodash
* node-colormin
* node-css-loader
* node-deep-for-each
* node-es6-promise
* node-handlebars
* node-i18next-http-backend

The actual fix in build output is just one line,

$ diff -u autosize-current.js autosize.js
--- autosize-current.js	2021-06-30 22:30:00.391798535 +0530
+++ autosize.js	2020-12-14 17:42:45.000000000 +0530
@@ -284,5 +284,5 @@

  var _default = autosize;
  _exports["default"] = _default;
-  module.exports = exports["default"];
+  module.exports = exports.default;
});
\ No newline at end of file

[ Tests ]
autosize.js is already tested with diaspora. autosize.js and 
node-babel-plugin-lodash already fixed in experimental. Remaining 
modules build status tracked in 
https://wiki.debian.org/Javascript/Nodejs/Transitions/Babel7#Reverse_build_dependencies_of_node-babel-plugin-add-module-exports

[ Risks ]
* autosize.js - only reverse dependency is diaspora which is not in 
bullseye (I hope to get diaspora in bullseye-backports after bullseye 
release)
* node-babel-plugin-lodash, node-colormin - leaf package (dependency of 
gitlab which is not in bullseye)
* node-deep-for-each - node-grunt-webpack is a reverse dependency
* node-es6-promise - ipywidgets, lumino, node-any-promise, 
node-mongodb, node-yargs in reverse build depends.

* node-handlebars -  node-istanbul and diaspora in reverse (build) deps
* node-i18next-http-backend - glewlwyd is a reverse build dependency

* node-css-loader has the following reverse build dependencies: 
ipywidgets, lumino, node-katex, node-mermaid, 
node-mini-css-extract-plugin, pdf.js, rainloop, shaarli, glewlwyd - not 
sure about the impact, likely unaffected as they may be consuming the 
ES6 module format instead of the generated files. Out of this 
node-katex, node-mermaid, node-mini-css-extract-plugin are only needed 
for gitlab.


[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
I'm personally okay if this is pushed to 11.1 or even 
bullseye-backports (but we will have to remove all these broken reverse 
dependencies).

debdiff.relevant shows the actual upstream change and debian directory.
debdiff.trimmed skips the three added components used only for tests 
(but tests are not enabled since one of them is not compatible with 
babel 7, I'd like to enable tests later so kept the embedded components 
in source)
debdiff.full shows the full debdiff.

unblock node-babel-plugin-add-module-exports/0.2.1-3


-------------- next part --------------
A non-text attachment was scrubbed...
Name: debdiff.relevant
Type: text/x-patch
Size: 25765 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20210701/d2b72a9a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debdiff.trimmed
Type: text/x-patch
Size: 64509 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20210701/d2b72a9a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debdiff.full
Type: text/x-patch
Size: 333269 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20210701/d2b72a9a/attachment-0002.bin>