[Pkg-javascript-devel] RFS:node-zrender

[Yadd]

Le 07/06/2021 à 15:39, Harish a écrit :
> Hi,
> 
> I've just packaged new node module, node-zrender 5.1.0+dfsg1, for debian
> and I wish to upload it to salsa debian js-team repository. Some  tests
> are not enabled but it was lintian clean and  it built with clean
> chroot  find it at:https://salsa.debian.org/Harish1/node-zrender
> 
> please consider to review and upload it .

Hi,

package is wrong at least for the following reasons:

I - DFSG

you imported compiled Javascript (the dist/ dir) and didn't regenerate
minified files. ToDo:
 * "Files-Excluded: dist/" in debian/copyright
 * reimport
 * generate "dist/" using something like:
   + tsc -m ES2015 --outDir lib
   + node build/build.js --minify

This requires probably some imports in debian/nodejs/extlinks or
debian/nodejs/extcopies (tsc)

II - Copyright

Copyright is wrong, at least for these files:
 * build/progress.js
 * src/core/OrientedBoundingRect.ts
 * test/-cases.html
 * test/css-transform-inverse.html
 * test/css-transform.html
 * test/lib/caseFrame.css
 * test/lib/caseFrame.js
 * test/lib/facePrint.js

III - Debian fields

debian/control: description is very bad

Cheers,
Yadd