[Pkg-javascript-devel] [RFS] node-typanion

[Yadd]

Le 08/05/2021 à 02:08, Sonnie Nkwuda a écrit :
> Hi there 👋 
> 
> I've just packaged a new node module, node-typanion 3.3.1, for Debian
> and I wish to find a sponsor to help me upload it to salsa Debian
> js-team repository.
> I ensured it's lintian clean and also built it in a clean chroot with
> sbuild.
> 
> Find it at:  https://salsa.debian.org/sonnie/node-typanion
> <https://salsa.debian.org/sonnie/node-typanion> .
> 
> Regards
> Sunday Nkwuda

Hi,

looks good, thanks. Build & autopkgtest & duck & lintian are OK. Just
some few things:

 * copyright is 2020, not 2021
 * in debian/tests/pkg-js/test:

     TS_NODE_TRANSPILE_ONLY=true

   has no effect, it should be removed or fixed:

     export TS_NODE_TRANSPILE_ONLY=true

 * in debian/control:
   * test-only build-dependencies should be marked with <!nocheck>
     (probably mocha and chai)
   * remove pkg-js-tools dependency: double with dh-sequence-nodejs

Sorry to not have look at this earlier, I'm hospitalized.

Cheers,
Yadd