[Pkg-javascript-devel] [RFS] node-cliui

[Yadd]

Le 04/11/2021 à 13:21, Ayoyimika Ajibade a écrit :
> Hi There!
> 
> I have updated node-cliui from version (4.1.0 ->  7.0.4) The package is
> available at https://salsa.debian.org/Ayoyimika/node-cliui and i am
> requesting for sponsorship and i ensured all tests passed with
> autopkgtest, it's lintian clean and built it in a clean chroot with sbuild.
> 
> Thanks

Hi,

I fixed and pushed. You embedded @types/node as component, never do that:
 * it's a build dependency, not a dependency
 * it's provided by nodejs itself, strongly avoid code duplication.

The problem you faced was that typescript didn't find @types/node
because of typescript behavior. In this case, use debian/nodejs/extlinks
or debian/nodejs/extcopies to link (or copy) not-found-modules in
./node_modules/

Cheers,
Yadd