[Pkg-javascript-devel] Bug#1000672: Bug#1000672: @lumino/polling isn't compiled correctly

[Yadd]

Le 27/11/2021 à 09:54, Yadd a écrit :
> Le 27/11/2021 à 09:44, Julien Puydt a écrit :
>> Hi,
>>
>> Le samedi 27 novembre 2021 à 09:24 +0100, Yadd a écrit :
>>>
>>> This is a known typescript bug, it is unable to use nodejs paths. To
>>> workaround, use this:
>>>
>>> $ cat > debian/nodejs/extlinks << EOF
>>> setimmediate
>>> @types/node
>>> EOF
>>
>> How does that work?
>>
>> Thanks,
> 
> typescript only looks at node_modules/ directories to find dependencies.
> dh-sequence-nodejs:
>  * link all modules declared in debian/nodejs/extlinks into
>    node_modules/
>  * copies all modules declared in debian/nodejs/extcopies into
>    node_modules (useful if a ts file launch another ts file)
> 
> See
> https://salsa.debian.org/js-team/pkg-js-tools/tree/master/doc/tools#readme

I took a look at your build script, you should add some "set -e" to be
sure that package is well compiled:

diff --git a/debian/rules b/debian/rules
index 17e83d3..436cf4b 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,7 +4,7 @@
        dh $@

 override_dh_auto_build:
-       for package in algorithm coreutils keyboard properties \
+       set -e && for package in algorithm coreutils keyboard properties \
                collections domutils signaling virtualdom \
                disposable messaging \
                datastore dragdrop commands polling \
@@ -14,7 +14,7 @@ override_dh_auto_build:
           && tsc && rollup lib/*.js -f cjs -m -d dist) ; \
        done
        ln -s packages/ @lumino
-       for example in example-datagrid ; do \
+       set -e && for example in example-datagrid ; do \
          (cd examples/$$example && echo "Compiling $$example" \
          && tsc && webpack) ; \
        done