[Pkg-javascript-devel] [RFS] -- node-tslib 2.3.1

[Vivek K J]

2021, സെപ്റ്റംബർ 7 4:37:16 PM IST, Nilesh Patra <nilesh at nileshpatra.info>ൽ എഴുതി
>On 9/7/21 4:23 PM, Vivek K J wrote:
>> 
>> On 07/09/21 3:39 pm, Nilesh Patra wrote:
>>> Hi Vivek,
>>>
>>> On 9/7/21 3:15 PM, VIVEK K J wrote:
>>>> Hi maintainers,
>>>>
>>>> I've been updated node-tslib package to 2.3.1 for one of my ongoing package.
>>> Cool, although this might not be a major change, but have you tried checking a few reverse-dependencies yet?
>> No. I haven't checked.
>>> Actually, node-rollup-plugin-typescript is a bit of an important one.
>>> Let me know.
>> 
>> Actually i was trying to pack rxjs node module. While building the package I got a error just like this:
>> This syntax requires an imported helper named '__spreadArray' which does not exist in 'tslib'. Consider upgrading your version of 'tslib'.ts(2343)
>> So on searching I got the solution is to update tslib to latest (^2.2.0). That's why I updated tslib to latest. (https://github.com/microsoft/TypeScript/issues/37991#issuecomment-836152360)
>
>Yeah, this is because of the API change in that function with this release, see here[1] (yellow color :))
>There is actually one more change, see this one[2] which might break certain things. Can I ask you to test a few reverse-dependencies
>with this new tslib? this script could help you accomplish that[3]
>

I just tried building reverse dependencies using the latest node-tslib. Lumino[1], node-ast-types[2] and node-recast[3] returned FAIL status. unfortunately I can't build node-rollup-plugin-typescript using the same script. (Waited over 2 hrs. :( ). So what's next ?
>OR,
>If you don't want to do this, can you grep the changed APIs in the sources of the important reverse dependencies, and see if this new update could
>possibly break it?
>
>>>>   updated package is available at
>>>> https://salsa.debian.org/vivekkj/node-tslib. Requesting for sponsorship.
>>> Looks good, why don't you push directly to the javascript team salsa?
>>> I see that you have maintainer access there already.
>> I thought I can't directly push to team repo without asking in mailing list.
>
>You can push anything you want, and whenever you'd like -- as long as you think it is sensible to push :)
>
>[1]: https://salsa.debian.org/vivekkj/node-tslib/-/commit/413e0a0b62d8d7774193629396d797e11fee2fd7#37af3f2db9a86ce32ebbf466e1ed9e804fbfd5ef_31_30
>[2]: https://salsa.debian.org/vivekkj/node-tslib/-/commit/413e0a0b62d8d7774193629396d797e11fee2fd7#80ee5ae52e68b8fb47aed1edb9da1bba2c7d4ddd_229_228
>[3]: https://salsa.debian.org/ruby-team/meta
>
>Nilesh
>
[1] => https://paste.debian.net/1210884/
[2] => https://paste.debian.net/1210885/
[3] => https://paste.debian.net/1210886/


Vivek K J
vivekkj.com