[Pkg-javascript-devel] Bug#994703: Bug#994703: Bug#994703: nodejs: please documents deps or avoid it

[Jérémy Lal]

Le dim. 19 sept. 2021 à 22:27, Bastien ROUCARIES <
roucaries.bastien at gmail.com> a écrit :

> Le dim. 19 sept. 2021 à 19:33, Jérémy Lal <kapouer at melix.org> a écrit :
> >
> >
> >
> > Le dim. 19 sept. 2021 à 18:54, Bastien Roucariès <
> roucaries.bastien at gmail.com> a écrit :
> >>
> >> Package: nodejs
> >> Version: 12.22.5~dfsg-2
> >> Severity: serious
> >>
> >> Dear Maintainer,
> >>
> >> README.source should document the deps directory.
> >>
> >> It will be better to remove some libs from deps. Why libz is needed for
> node ?
> >> Could we push this plugin stuff to libz and so on.
> >>
> >> Acorn embdeded should be fixed by recent version.
> >>
> >> openssl one is worry some..
> >
> >
> > Hi,
> >
> > What's in ./deps/ is mostly not used for building node.
> > It's pretty much obvious if you look at ./debian/rules configure flags.
>
> Yes but README.Source is in this case good
> >
> > I believe it is not common practice to remove unused files, as long as
> it's okay with DFSG.
> Yes also
> > That's why
> > zlib, openssl, nghttp2, http-parser, uv, c-ares, brotli
> > are kept around in ./deps/ directory.
> >
> > This is actually useful, it makes debugging against "upstream-like"
> builds easier.
>
> Yes but in order to be less worried about something in this huge code
> base use these files, I will really prefer to move the deps dir before
> configure or removing the -r bit in order to avoid something strange
>
> I was hit ten years ago by some leaking hardcoded path on a project I
> compiled, and I really prefer to be paraonoiac on this side
>

Yes, why not. Better safe than sorry.

Jérémy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20210919/c8cbb898/attachment.htm>