[Pkg-javascript-devel] Bug#922075: Bug#922075: npm: segfault during extract on i386

[Ondrej Zary]

On Monday 20 September 2021 19:31:56 Bastien ROUCARIES wrote:
> Le lun. 20 sept. 2021 à 17:28, Jérémy Lal <kapouer at melix.org> a écrit :
> >
> >
> >
> > Le lun. 20 sept. 2021 à 19:15, Ondrej Zary <ondrej at zary.sk> a écrit :
> > >
> > > On Monday 20 September 2021 16:56:18 Bastien ROUCARIES wrote:
> > > > Le lun. 20 sept. 2021 à 14:24, Ondrej Zary <ondrej at zary.sk> a écrit :
> > > > >
> > > > > On Monday 20 September 2021, Bastien ROUCARIES wrote:
> > > > > > Could you try to apply
> > > > > >
> > > > > > https://github.com/nodejs/node/commit/aa4611cccbcb197df51a9f7056d019005d91acf4
> > > > > >
> > > > > > I think it describe that you see
> > > > >
> > > > > Does not apply, unfortunately. There's no node_dir.cc file and also no BaseObjectPtr definition.
> > > >
> > > > Ok as band aid could you replace in the patch BaseObjectPtr by
> > > > std:shared_ptr<ObjectPtr>
> > >
> > > Biggest problem is the missing node_dir.cc file. The patched code from that file is not present at all in nodejs 10.
> >
> > Wild guess, try only that part:
> >
> > - delete wrap_;
> > + wrap_->Detach();
> > + wrap_.reset();
> Yes but reset is std:shared_ptr<ObjectPtr>
> 
> But I agree it is the main part of the patch

Detach() is also not defined in src/base_object.h


-- 
Ondrej Zary