[Pkg-javascript-devel] Bug#994938: ITP: node-strtok3 -- Promise based streaming tokenizer for Node.js and browsers

[Yadd]

Le 23/09/2021 à 17:05, Vivek K J a écrit :
> 
> 
> On 23 September 2021 8:33:11 pm IST, Yadd <yadd at debian.org> wrote:
>> Le 23/09/2021 à 16:19, Vivek K J a écrit :
>>>
>>> On 23/09/21 7:44 pm, Yadd wrote:
>>>> Le 23/09/2021 à 16:04, Vivek K J a écrit :
>>>>> Package: wnpp
>>>>> Severity: wishlist
>>>>> Owner: Vivek K J <vivekkj at protonmail.com>
>>>>> X-Debbugs-Cc: debian-devel at lists.debian.org, vivekkj at protonmail.com
>>>>>
>>>>> * Package name    : node-strtok3
>>>>>    Version         : 6.2.4
>>>>>    Upstream Author : Borewit (https://github.com/Borewit)
>>>>> * URL             : https://github.com/Borewit/strtok3#readme
>>>>> * License         : Expat
>>>>>    Programming Lang: Javascript
>>>>>    Description     : Promise based streaming tokenizer for Node.js
>>>>> and browsers
>>>>>
>>>>> A promise based streaming tokenizer for Node.js and browsers. This
>>>>> node module
>>>>>   is a successor of strtok2.
>>>>>   .
>>>>>   The strtok3 contains a few methods to turn different input into a
>>>>> tokenizer.
>>>>>   Designed to:
>>>>>      Support a streaming environment
>>>>>      Decoding of binary data, strings and numbers in mind
>>>>>      Read predefined or custom tokens.
>>>>>      Optimized tokenizers for reading from file, stream or buffer.
>>>>>   .
>>>>>   Node.js is an event-based server-side JavaScript engine.
>>>>> This package will be maintained by Javascript packaging team.
>>>> * autopkgtest fails (missing build dependency to ts-node)
>>>> * copyright: 2017, not 2021
>>>> * debhelper 13
>>>> * dh-sequence-nodejs, not pk-js-tools (remove also --with nodejs)
>>>> * Missing "Rules-Requires-Root: no"
>>>> * boiterpoilate in debian/control
>>>>
>>>
>>> Corrected, check now: https://salsa.debian.org/js-team/node-strtok3
>>
>> autopkgtest still fails:
>>
>>  1) fromStream()
>>       Transparency:
>>     AssertionError: expected [TypeError: buf.readUInt8 is not a
>> function] to be an instance of EndOfStreamError
>>      at Context.<anonymous>
>> (/tmp/autopkgtest.iX8zyc/autopkgtest_tmp/smokeC1If7w/test/test.ts:522:16)
>>      at processTicksAndRejections (internal/process/task_queues.js:97:5)
>>
>>  2) fromStream()
>>       number:
>>     TypeError: buf.readInt32BE is not a function
>>      at Object.get
>> (/tmp/autopkgtest.iX8zyc/autopkgtest_tmp/smokeC1If7w/node_modules/token-types/lib/index.js:156:20)
>>      at ReadStreamTokenizer.peekNumber
>> (/usr/share/nodejs/strtok3/lib/AbstractTokenizer.js:63:22)
>>      at processTicksAndRejections (internal/process/task_queues.js:97:5)
>>      at Context.<anonymous>
>> (/tmp/autopkgtest.iX8zyc/autopkgtest_tmp/smokeC1If7w/test/test.ts:651:17)
>>
>>  3) fromFile()
>>       Transparency:
>>     AssertionError: expected [TypeError: buf.readUInt8 is not a
>> function] to be an instance of EndOfStreamError
>>      at Context.<anonymous>
>> (/tmp/autopkgtest.iX8zyc/autopkgtest_tmp/smokeC1If7w/test/test.ts:522:16)
>>
>>  4) fromFile()
>>       number:
>>     TypeError: buf.readInt32BE is not a function
>>      at Object.get
>> (/tmp/autopkgtest.iX8zyc/autopkgtest_tmp/smokeC1If7w/node_modules/token-types/lib/index.js:156:20)
>>      at FileTokenizer.peekNumber
>> (/usr/share/nodejs/strtok3/lib/AbstractTokenizer.js:63:22)
>>      at Context.<anonymous>
>> (/tmp/autopkgtest.iX8zyc/autopkgtest_tmp/smokeC1If7w/test/test.ts:651:17)
>>
>>  5) fromBuffer()
>>       Transparency:
>>     AssertionError: expected [TypeError: buf.readUInt8 is not a
>> function] to be an instance of EndOfStreamError
>>      at Context.<anonymous>
>> (/tmp/autopkgtest.iX8zyc/autopkgtest_tmp/smokeC1If7w/test/test.ts:522:16)
>>
>>  6) fromBuffer()
>>       number:
>>     TypeError: buf.readInt32BE is not a function
>>      at Object.get
>> (/tmp/autopkgtest.iX8zyc/autopkgtest_tmp/smokeC1If7w/node_modules/token-types/lib/index.js:156:20)
>>      at BufferTokenizer.peekNumber
>> (/usr/share/nodejs/strtok3/lib/AbstractTokenizer.js:63:22)
>>      at Context.<anonymous>
>> (/tmp/autopkgtest.iX8zyc/autopkgtest_tmp/smokeC1If7w/test/test.ts:651:17)
>>
> I don't know why, the autopkgtest fails. It may be because the version mismatch of @type/node in upstream and Debian repos.

you should build and test in a clean tree (schroot for example). If your
package requires nodejs ≥ 14, target should be "experimental", not
"unstable".
Wait a little for now, nodejs/pkg-js-tools are incompatible for now
(missing nodejs:any in experimental)

Cheers,
Yadd