[Pkg-javascript-devel] Bug#1007858: Bug#1007858: Bug#1007858: node-lodash: FTBFS with nodejs experimental/14.19.0

[Jérémy Lal]

On Wed, Apr 6, 2022 at 6:30 PM Jonas Smedegaard <jonas at jones.dk> wrote:

> Quoting Yadd (2022-04-06 18:12:30)
> > On 19/03/2022 08:38, Yadd wrote:
> > > On 19/03/2022 08:11, Yadd wrote:
> > >> On 17/03/2022 19:21, Jérémy Lal wrote:
> > >>> Source: node-lodash
> > >>> Version: 4.17.21+dfsg+~cs8.31.196.20210220-2
> > >>> Severity: important
> > >>> Tags: ftbfs
> > >>>
> > >>> This package fails to rebuild. Build log is attached.
> > >>
> > >> The real problem comes from uglify-js call. Build works fine with
> > >> uglifyjs 2 (as required by node-locash/package.json) but fails with
> > >> uglify-js 3. Here is the real error:
> > >>
> > >>    error: JS_Parse_Error [SyntaxError]: Invalid flags supplied to
> > >> RegExp constructor 'node'
> > >>        at JS_Parse_Error.get (eval at <anonymous>
> > >>
> (/build/node-lodash-wQJpO3/node-lodash-4.17.21+dfsg+~cs8.31.198.20210220/node_modules/uglify-js/tools/node.js:18:1),
>
> > >> <anonymous>:63:23)
> > >>        at formatError (internal/util/inspect.js:1149:38)
> > >>        at formatRaw (internal/util/inspect.js:919:14)
> > >>        at formatValue (internal/util/inspect.js:774:10)
> > >>        at formatProperty (internal/util/inspect.js:1660:11)
> > >>        at formatRaw (internal/util/inspect.js:987:9)
> > >>        at formatValue (internal/util/inspect.js:774:10)
> > >>        at inspect (internal/util/inspect.js:319:10)
> > >>        at formatWithOptionsInternal (internal/util/inspect.js:1979:40)
> > >>        at formatWithOptions (internal/util/inspect.js:1861:10) {
> > >>      filename: '0',
> > >>      line: 1,
> > >>      col: 0,
> > >>      pos: 0
> > >
> > > For now, I dropped internal minifier and pushed result to
> experimental.
> > > This may break some builds: minified files have to be generated
> separately.
> > >
> > > Can someone else have a look at this ?
> >
> > I'm unable to reproduce this failure in an up-to-date schroot, but build
> > fails in salsa CI [1], that's why I reopened this issue.
> >
> > [1]: https://salsa.debian.org/js-team/node-lodash/-/jobs/2648172
>
> Maybe check if upstream has a branch or pending MR with code to upgrade
> to UglifyJS v3?
>

It's mainly useless code coming from lodash-cli.
The mistake here is that build-dist.js is actually called.
It does just copy a file and wrongly call uglifyjs, which is done in
debian/rules properly anyway.

Please someone remind us to upload the fix when build deps conflicts are
fixed...

Jérémy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20220407/af0dcb34/attachment.htm>