[Pkg-javascript-devel] Bug#1009484: node-copy-concurrently: FTBFS: ERROR: Coverage for statements (97.91%) does not meet global threshold (100%)

[Lucas Nussbaum]

Source: node-copy-concurrently
Version: 1.0.5-8
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20220412 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
>  debian/rules binary
> dh binary
>    dh_update_autotools_config
>    dh_autoreconf
>    dh_auto_configure --buildsystem=nodejs
>    dh_auto_build --buildsystem=nodejs
> No build command found, searching known files
>    dh_auto_test --buildsystem=nodejs
> 	mkdir -p node_modules
> 	ln -s ../. node_modules/copy-concurrently
> 	/bin/sh -ex debian/tests/pkg-js/test
> + tap -R spec test
> 
> (node:4048760) DeprecationWarning: is() is deprecated, use equal() instead
> (Use `node --trace-deprecation ...` to show where the warning was created)
> test/copy.js
>   copy errors
> 
>     ✓ dest exists
> 
>     ✓ dest perm error
> 
>     ✓ source does not exist
> 
>     ✓ block devices unsupported
> 
>     ✓ char devices unsupported
> 
>     ✓ FIFOs unsupported
> 
>     ✓ sockets unsupported
> 
>     ✓ unknown unsupported
> 
>   copy file
> 
>     ✓ CHOWN uid:100
> 
>     ✓ read errors propagate
> 
>     ✓ write errors propagate
> 
>     ✓ copy ok
> 
>     ✓ CHMOD: dest:chmod 33188
> 
>     ✓ copy w/chmod ok
> 
>     ✓ copy w/chown ok
> 
>   copy symlink unix
> 
>     ✓ symlink type ../other/src:ok → dest:ok
> 
>     ✓ symlink type ../other/src:dir-ok → dest:ok
> 
>     ✓ file symlink ok
> 
>     ✓ dir symlink ok
> 
>     ✓ failed file symlink fails
> 
>     ✓ failed dir symlink fails
> 
>   copy symlink windows
> 
>     ✓ symlink type ../other/src:ok → dest:ok
> 
>     ✓ symlink type ../other/src:dir-ok → dest:ok
> 
>     ✓ symlink type ../other/src:junction-ok → dest:ok
> 
>     ✓ file symlink ok
> 
>     ✓ dir symlink ok
> 
>     ✓ failed file symlink fails
> 
>     ✓ dir junction fallback ok
> 
>     ✓ failed dir symlink fails
> 
> (node:4048759) DeprecationWarning: is() is deprecated, use equal() instead
> (Use `node --trace-deprecation ...` to show where the warning was created)
> test/integration.js
>   setup
> 
>     1) t.done is not a function
> 
>   copy
> 
>     ✓ copied symlink
> 
>     ✓ copied dir symlink
> 
>     ✓ won't overwrite symlinks
> 
>     2) (unnamed test)
> 
>     3) (unnamed test)
> 
>     4) test unfinished
> 
>     5) test count !== plan
> 
> 
>   6) child test left in queue: t.test cleanup
> 
>   7) test count !== plan
> 
>   32 passing (1s)
>   7 failing
> 
>   1) test/integration.js setup t.done is not a function:
>      Error: t.done is not a function
>       at Test.<anonymous> (test/integration.js:59:5)
>       at Test.cb (/usr/share/nodejs/libtap/lib/test.js:127:40)
>       at /usr/share/nodejs/libtap/lib/test.js:369:21
>       at Test.main (/usr/share/nodejs/libtap/lib/test.js:376:7)
>       at Test.runMain (/usr/share/nodejs/libtap/lib/base.js:178:15)
>       at /usr/share/nodejs/libtap/lib/test.js:485:13
>       at TAP.writeSubComment (/usr/share/nodejs/libtap/lib/test.js:556:5)
>       at Test.<anonymous> (/usr/share/nodejs/libtap/lib/test.js:484:14)
> 
>   2) test/integration.js copy (unnamed test):
>      (unnamed test)
>   
> 
>   3) test/integration.js copy (unnamed test):
>      (unnamed test)
>   
> 
>   4) test/integration.js copy test unfinished:
>      Error: test unfinished
>       at Object.<anonymous> (test/integration.js:62:1)
>       at Module.replacementCompile (/usr/share/nodejs/append-transform/index.js:60:13)
>       at Object.<anonymous> (/usr/share/nodejs/append-transform/index.js:64:4)
> 
>   5) test/integration.js copy test count !== plan:
> 
>       test count !== plan
>       + expected - actual
> 
>       -6
>       +7
>       
>   
> 
>   6) test/integration.js child test left in queue: t.test cleanup:
>      child test left in queue: t.test cleanup
>   
> 
>   7) test/integration.js test count !== plan:
> 
>       test count !== plan
>       + expected - actual
> 
>       -3
>       +2
>       
>   
> 
> ERROR: Coverage for lines (99.23%) does not meet global threshold (100%)
> ERROR: Coverage for functions (96.42%) does not meet global threshold (100%)
> ERROR: Coverage for branches (75%) does not meet global threshold (100%)
> ERROR: Coverage for statements (97.91%) does not meet global threshold (100%)
> ---------------|---------|----------|---------|---------|-------------------
> File           | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
> ---------------|---------|----------|---------|---------|-------------------
> All files      |   97.91 |       75 |   96.42 |   99.23 |                   
>  copy.js       |    97.9 |       75 |   96.42 |   99.22 | 134               
>  is-windows.js |     100 |      100 |     100 |     100 |                   
> ---------------|---------|----------|---------|---------|-------------------
> dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 1


The full build log is available from:
http://qa-logs.debian.net/2022/04/12/node-copy-concurrently_1.0.5-8_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220412;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220412&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.