[Pkg-javascript-devel] Bug#1009516: node-buffer-crc32: FTBFS: ERROR: Coverage for branches (81.25%) does not meet global threshold (100%)

[Lucas Nussbaum]

Source: node-buffer-crc32
Version: 0.2.13+~0.2.0-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20220412 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
>  debian/rules binary
> dh binary
>    dh_update_autotools_config
>    dh_autoreconf
>    dh_auto_configure --buildsystem=nodejs
> Link node_modules/@types/buffer-crc32 -> ../../types-buffer-crc32
>    dh_auto_build --buildsystem=nodejs
> No build command found, searching known files
> No build command found, searching known files
>    dh_auto_test --buildsystem=nodejs
> 	ln -s ../. node_modules/buffer-crc32
> 	/bin/sh -ex debian/tests/pkg-js/test
> + tap tests/crc.test.js
> TAP version 13
> (node:1604073) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
> (Use `node --trace-deprecation ...` to show where the warning was created)
> ok 1 - tests/crc.test.js # time=91.948ms {
>     # Subtest: simple crc32 is no problem
>         ok 1 - should be equivalent
>         1..1
>     ok 1 - simple crc32 is no problem # time=12.255ms
>     
>     # Subtest: another simple one
>         ok 1 - should be equivalent
>         1..1
>     ok 2 - another simple one # time=1.521ms
>     
>     # Subtest: slightly more complex
>         ok 1 - should be equivalent
>         1..1
>     ok 3 - slightly more complex # time=1.05ms
>     
>     # Subtest: complex crc32 gets calculated like a champ
>         ok 1 - should be equivalent
>         1..1
>     ok 4 - complex crc32 gets calculated like a champ # time=1.104ms
>     
>     # Subtest: casts to buffer if necessary
>         ok 1 - should be equivalent
>         1..1
>     ok 5 - casts to buffer if necessary # time=0.83ms
>     
>     # Subtest: can do signed
>         ok 1 - should be equivalent
>         1..1
>     ok 6 - can do signed # time=0.708ms
>     
>     # Subtest: can do unsigned
>         ok 1 - should be equivalent
>         1..1
>     ok 7 - can do unsigned # time=3.155ms
>     
>     # Subtest: simple crc32 in append mode
>         ok 1 - should be equivalent
>         1..1
>     ok 8 - simple crc32 in append mode # time=4.802ms
>     
>     # Subtest: can do signed in append mode
>         ok 1 - should be equivalent
>         1..1
>     ok 9 - can do signed in append mode # time=2.473ms
>     
>     # Subtest: make sure crc32 can accept integers as first arg 
>         ok 1 - should be equivalent
>         1..1
>     ok 10 - make sure crc32 can accept integers as first arg # time=3.446ms
>     
>     # Subtest: make sure crc32 throws on bad input
>         ok 1 - expect truthy value
>         1..1
>     ok 11 - make sure crc32 throws on bad input # time=1.839ms
>     
>     # Subtest: can do unsigned in append mode
>         ok 1 - should be equivalent
>         1..1
>     ok 12 - can do unsigned in append mode # time=3.48ms
>     
>     1..12
>     # time=91.948ms
> }
> 
> 1..1
> # time=981.649ms
> ERROR: Coverage for branches (81.25%) does not meet global threshold (100%)
> ----------|---------|----------|---------|---------|-------------------
> File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
> ----------|---------|----------|---------|---------|-------------------
> All files |     100 |    81.25 |     100 |     100 |                   
>  index.js |     100 |    81.25 |     100 |     100 | 58,72,75          
> ----------|---------|----------|---------|---------|-------------------
> dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 1


The full build log is available from:
http://qa-logs.debian.net/2022/04/12/node-buffer-crc32_0.2.13+~0.2.0-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220412;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220412&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.