[Pkg-javascript-devel] Bug#1009546: node-browserify-zlib: FTBFS: ERROR: Coverage for statements (89.57%) does not meet global threshold (100%)
Lucas Nussbaum
lucas at debian.org
Tue Apr 12 20:18:06 BST 2022
Source: node-browserify-zlib
Version: 0.2.0+20170820git8b3f0a862f6b+dfsg-6
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20220412 ftbfs-bookworm
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
Relevant part (hopefully):
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> babeljs src/ --out-dir lib
> Successfully compiled 2 files with Babel (407ms).
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> dh_auto_test --buildsystem=nodejs
> mkdir -p node_modules
> ln -s ../. node_modules/browserify-zlib
> /bin/sh -ex debian/tests/pkg-js/test
> + convert rose: test/fixtures/person.jpg
> + gzip -9 -n
> + tap -R spec test/test-zlib-close-after-error.js test/test-zlib-close-after-write.js test/test-zlib-const.js test/test-zlib-convenience-methods.js test/test-zlib-dictionary-fail.js test/test-zlib-dictionary.js test/test-zlib-flush-drain.js test/test-zlib-flush-flags.js test/test-zlib-from-concatenated-gzip.js test/test-zlib-from-gzip.js test/test-zlib-from-string.js test/test-zlib-invalid-input.js test/test-zlib-random-byte-pipes.js test/test-zlib-sync-no-event.js test/test-zlib-truncated.js test/test-zlib-unzip-one-byte-chunks.js test/test-zlib-write-after-close.js test/test-zlib-write-after-flush.js test/test-zlib-zero-byte.js test/test-zlib.js
>
> test/test-zlib-close-after-error.js
> - test/test-zlib-close-after-error.js
> test/test-zlib-close-after-write.js
> - test/test-zlib-close-after-write.js
> test/test-zlib-const.js
> - test/test-zlib-const.js
> test/test-zlib-convenience-methods.js
> - test/test-zlib-convenience-methods.js
> test/test-zlib-dictionary-fail.js
> - test/test-zlib-dictionary-fail.js
> test/test-zlib-dictionary.js
> - test/test-zlib-dictionary.js
> test/test-zlib-flush-drain.js
> - test/test-zlib-flush-drain.js
> test/test-zlib-flush-flags.js
> - test/test-zlib-flush-flags.js
> Doing the non-strings
> assert.js:118
> throw new AssertionError(obj);
> ^
>
> AssertionError [ERR_ASSERTION]: Got unwanted exception.
> Actual message: "The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received type number (1)"
> at /<<PKGBUILDDIR>>/test/test-zlib-invalid-input.js:13:10
> at Array.forEach (<anonymous>)
> at Object.<anonymous> (/<<PKGBUILDDIR>>/test/test-zlib-invalid-input.js:11:17)
> at Module._compile (internal/modules/cjs/loader.js:1085:14)
> at Module.replacementCompile (/usr/share/nodejs/append-transform/index.js:60:13)
> at Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
> at Object.<anonymous> (/usr/share/nodejs/append-transform/index.js:64:4)
> at Module.load (internal/modules/cjs/loader.js:950:32)
> at Function.Module._load (internal/modules/cjs/loader.js:790:12)
> at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12) {
> generatedMessage: false,
> code: 'ERR_ASSERTION',
> actual: TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received type number (1)
> at new NodeError (internal/errors.js:322:7)
> at Gunzip.Writable.write (internal/streams/writable.js:285:13)
> at Gunzip.Writable.end (internal/streams/writable.js:567:10)
> at zlibBuffer (/<<PKGBUILDDIR>>/lib/index.js:11:4004)
> at Object.exports.gunzip (/<<PKGBUILDDIR>>/lib/index.js:11:2960)
> at /<<PKGBUILDDIR>>/test/test-zlib-invalid-input.js:14:10
> at getActual (assert.js:753:5)
> at Function.doesNotThrow (assert.js:919:32)
> at /<<PKGBUILDDIR>>/test/test-zlib-invalid-input.js:13:10
> at Array.forEach (<anonymous>) {
> code: 'ERR_INVALID_ARG_TYPE'
> },
> expected: undefined,
> operator: 'doesNotThrow'
> }
> block=249
> remain=775
>
> inp data 249
> gzip data 10
> block=260
> remain=515
>
> inp data 260
> block=252
> remain=263
>
> inp data 252
> block=251
> remain=12
>
> inp data 251
> block=12
> remain=0
>
> inp data 12
> (node:1322272) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
> (Use `node --trace-deprecation ...` to show where the warning was created)
> gzip data 1037
> gunz data 1024
> out data 40
> hash=8f61a164c25fb8be3d1db8a1df66cea056027709
> test/test-zlib-from-concatenated-gzip.js
> - test/test-zlib-from-concatenated-gzip.js
> test/test-zlib-from-gzip.js
> - test/test-zlib-from-gzip.js
> test/test-zlib-from-string.js
> - test/test-zlib-from-string.js
> test/test-zlib-invalid-input.js
>
> 1) test/test-zlib-invalid-input.js
> test/test-zlib-random-byte-pipes.js
> - test/test-zlib-random-byte-pipes.js
> test/test-zlib-sync-no-event.js
> - test/test-zlib-sync-no-event.js
> test/test-zlib-truncated.js
> - test/test-zlib-truncated.js
> test/test-zlib-unzip-one-byte-chunks.js
> - test/test-zlib-unzip-one-byte-chunks.js
> assert.js:118
> throw new AssertionError(obj);
> ^
>
> AssertionError [ERR_ASSERTION]: Missing expected exception.
> at /<<PKGBUILDDIR>>/test/test-zlib-write-after-close.js:9:10
> at /<<PKGBUILDDIR>>/test/common.js:63:15
> at Gzip.onEnd (/<<PKGBUILDDIR>>/lib/index.js:11:4953)
> at Gzip.emit (events.js:412:35)
> at endReadableNT (internal/streams/readable.js:1334:12)
> at processTicksAndRejections (internal/process/task_queues.js:82:21) {
> generatedMessage: false,
> code: 'ERR_ASSERTION',
> actual: undefined,
> expected: undefined,
> operator: 'throws'
> }
> test/test-zlib-write-after-close.js
>
> 2) test/test-zlib-write-after-close.js
> test/test-zlib-write-after-flush.js
> - test/test-zlib-write-after-flush.js
> test/test-zlib-zero-byte.js
> - test/test-zlib-zero-byte.js
> test/test-zlib.js
>
> ✓ empty.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Deflate -> Inflate
>
> ✓ empty.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Gzip -> Gunzip
>
> ✓ empty.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Deflate -> Unzip
>
> ✓ empty.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Gzip -> Unzip
>
> ✓ empty.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} DeflateRaw -> InflateRaw
>
> ✓ person.jpg 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Deflate -> Inflate
>
> ✓ person.jpg 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Gzip -> Gunzip
>
> ✓ person.jpg 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Deflate -> Unzip
>
> ✓ person.jpg 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Gzip -> Unzip
>
> ✓ person.jpg 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} DeflateRaw -> InflateRaw
>
> ✓ elipses.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Deflate -> Inflate
>
> ✓ elipses.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Gzip -> Gunzip
>
> ✓ elipses.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Deflate -> Unzip
>
> ✓ elipses.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} Gzip -> Unzip
>
> ✓ elipses.txt 16384 {"level":6,"windowBits":15,"memLevel":8,"strategy":0} DeflateRaw -> InflateRaw
>
> 15 passing (3s)
> 17 pending
> 2 failing
>
> 1) test/test-zlib-invalid-input.js test/test-zlib-invalid-input.js:
> test/test-zlib-invalid-input.js
>
>
> 2) test/test-zlib-write-after-close.js test/test-zlib-write-after-close.js:
> test/test-zlib-write-after-close.js
>
>
> ERROR: Coverage for lines (91.42%) does not meet global threshold (100%)
> ERROR: Coverage for functions (92.53%) does not meet global threshold (100%)
> ERROR: Coverage for branches (78.01%) does not meet global threshold (100%)
> ERROR: Coverage for statements (89.57%) does not meet global threshold (100%)
> ------------|---------|----------|---------|---------|----------------------------------------------
> File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
> ------------|---------|----------|---------|---------|----------------------------------------------
> All files | 89.57 | 78.01 | 92.53 | 91.42 |
> binding.js | 92.3 | 84.44 | 94.11 | 92.3 | ...5,175,184,190,227,310,356,360,386,407,411
> index.js | 87.84 | 73.4 | 92 | 90.81 | ...9,335,340-341,347,391-413,439,441,529-531
> ------------|---------|----------|---------|---------|----------------------------------------------
> dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 1
The full build log is available from:
http://qa-logs.debian.net/2022/04/12/node-browserify-zlib_0.2.0+20170820git8b3f0a862f6b+dfsg-6_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220412;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220412&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
More information about the Pkg-javascript-devel
mailing list