[Pkg-javascript-devel] Bug#1009559: node-falafel: FTBFS: ERROR: Coverage for statements (98.11%) does not meet global threshold (100%)

[Lucas Nussbaum]

Source: node-falafel
Version: 2.2.4-3
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20220412 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
>  debian/rules binary
> dh binary
>    dh_update_autotools_config
>    dh_autoreconf
>    dh_auto_configure --buildsystem=nodejs
>    dh_auto_build --buildsystem=nodejs
> No build command found, searching known files
>    dh_auto_test --buildsystem=nodejs
> 	mkdir -p node_modules
> 	ln -s ../. node_modules/falafel
> 	/bin/sh -ex debian/tests/pkg-js/test
> + tap -R spec test/array.js test/async.js test/custom-parser.js test/es6.js test/for.js test/inspect.js test/opts.js test/parent.js
> 
> Since Acorn 8.0.0, options.ecmaVersion is required.
> Defaulting to 2020, but this will stop working in the future.
> Since Acorn 8.0.0, options.ecmaVersion is required.
> Defaulting to 2020, but this will stop working in the future.
> Since Acorn 8.0.0, options.ecmaVersion is required.
> Defaulting to 2020, but this will stop working in the future.
> Since Acorn 8.0.0, options.ecmaVersion is required.
> Defaulting to 2020, but this will stop working in the future.
> Since Acorn 8.0.0, options.ecmaVersion is required.
> Defaulting to 2020, but this will stop working in the future.
> Since Acorn 8.0.0, options.ecmaVersion is required.
> Defaulting to 2020, but this will stop working in the future.
> test/array.js
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> test/async.js
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> test/custom-parser.js
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> test/es6.js
> 
>   ✓ should be strictly equal
> test/for.js
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> test/inspect.js
> 
>   ✓ should be strictly equal
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> test/opts.js
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> 
>   ✓ should be deeply equivalent
> test/parent.js
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   ✓ should be strictly equal
> 
>   74 passing (2s)
> ERROR: Coverage for lines (98%) does not meet global threshold (100%)
> ERROR: Coverage for functions (90%) does not meet global threshold (100%)
> ERROR: Coverage for branches (94.28%) does not meet global threshold (100%)
> ERROR: Coverage for statements (98.11%) does not meet global threshold (100%)
> ----------|---------|----------|---------|---------|-------------------
> File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
> ----------|---------|----------|---------|---------|-------------------
> All files |   98.11 |    94.28 |      90 |      98 |                   
>  index.js |   98.11 |    94.28 |      90 |      98 | 28                
> ----------|---------|----------|---------|---------|-------------------
> dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 1


The full build log is available from:
http://qa-logs.debian.net/2022/04/12/node-falafel_2.2.4-3_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220412;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220412&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.