[Pkg-javascript-devel] Bug#1009583: node-difflet: FTBFS: ERROR: Coverage for statements (74.82%) does not meet global threshold (100%)

[Lucas Nussbaum]

Source: node-difflet
Version: 1.0.1-3
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20220412 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
>  debian/rules binary
> dh binary
>    dh_update_autotools_config
>    dh_autoreconf
>    dh_auto_configure --buildsystem=nodejs
>    dh_auto_build --buildsystem=nodejs
> No build command found, searching known files
>    dh_auto_test --buildsystem=nodejs
> 	mkdir -p node_modules
> 	ln -s ../debian/tests/test_modules/ent node_modules/ent
> 	ln -s ../. node_modules/difflet
> 	/bin/sh -ex debian/tests/pkg-js/test
> + tap -J test/diffing-NaN.js test/html.js test/object_tests.js
> TAP version 13
> (node:525363) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
> (Use `node --trace-deprecation ...` to show where the warning was created)
> ok 1 - test/diffing-NaN.js # time=22.16ms {
>     # Subtest: diffing NaN against NaN
>         1..1
>         ok 1 - should be equal
>     ok 1 - diffing NaN against NaN # time=6.605ms
>     
>     # Subtest: diffing { o: NaN } against { o: NaN }
>         1..1
>         ok 1 - should be equal
>     ok 2 - diffing { o: NaN } against { o: NaN } # time=2.104ms
>     
>     1..2
>     # time=22.16ms
> }
> 
> (node:525362) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
> (Use `node --trace-deprecation ...` to show where the warning was created)
> ok 2 - test/html.js # time=23.063ms {
>     # Subtest: html output
>         1..1
>         ok 1 - should be equal
>     ok 1 - html output # time=15.411ms
>     
>     # Subtest: compare html output
>         1..1
>         ok 1 - should be equal
>     ok 2 - compare html output # time=2.394ms
>     
>     1..2
>     # time=23.063ms
> }
> 
> ok 3 - test/object_tests.js # time=30.609ms {
>     # Subtest: diffing with empty nested array
>         1..1
>         ok 1 - should be equal
>     ok 1 - diffing with empty nested array # time=10.307ms
>     
>     # Subtest: diffing nested array with missing values
>         1..1
>         ok 1 - should be equal
>     ok 2 - diffing nested array with missing values # time=1.956ms
>     
>     # Subtest: diffing nested array with added values
>         1..1
>         ok 1 - should be equal
>     ok 3 - diffing nested array with added values # time=7.705ms
>     
>     1..3
>     # time=30.609ms
> }
> 
> 1..3
> # time=1474.384ms
> ERROR: Coverage for lines (76.51%) does not meet global threshold (100%)
> ERROR: Coverage for functions (80%) does not meet global threshold (100%)
> ERROR: Coverage for branches (64.41%) does not meet global threshold (100%)
> ERROR: Coverage for statements (74.82%) does not meet global threshold (100%)
> ---------------------------------------|---------|----------|---------|---------|-------------------
> File                                   | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
> ---------------------------------------|---------|----------|---------|---------|-------------------
> All files                              |   74.82 |    64.41 |      80 |   76.51 |                   
>  node-difflet-1.0.1                    |   77.07 |    65.89 |   88.23 |   79.22 |                   
>   index.js                             |   77.07 |    65.89 |   88.23 |   79.22 | ...49,367,376,379 
>  ....0.1/debian/tests/test_modules/ent |   57.57 |    47.82 |   33.33 |   57.57 |                   
>   index.js                             |   57.57 |    47.82 |   33.33 |   57.57 | 13,26,35-59       
> ---------------------------------------|---------|----------|---------|---------|-------------------
> dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 1


The full build log is available from:
http://qa-logs.debian.net/2022/04/12/node-difflet_1.0.1-3_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220412;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220412&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.