[Pkg-javascript-devel] Bug#1009605: node-browser-pack: FTBFS: ERROR: Coverage for statements (94.36%) does not meet global threshold (100%)

[Lucas Nussbaum]

Source: node-browser-pack
Version: 6.1.0+ds+~6.1.1-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20220412 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> uglifyjs -m < prelude.js  | sed -e 's/;[[:space:]]*$//g' -e '/^[[:space:]]*$/d' | tr -d '\n' > _prelude.mangle.js
> uglifyjs -c unused=false,expression=true,passes=5  < _prelude.mangle.js | sed -e 's/;[[:space:]]*$//g' -e '/^[[:space:]]*$/d' | tr -d '\n' > _prelude.js
> dh override_dh_auto_build
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_auto_test --buildsystem=nodejs
> 	ln -s ../. node_modules/browser-pack
> 	/bin/sh -ex debian/tests/pkg-js/test
> + tap -R spec test/comment.js test/empty.js test/not_found.js test/only_execute_entries.js test/order.js test/pack.js test/raw.js test/source-maps-existing.js test/source-maps.js test/this.js test/unicode.js
> 
> (node:217151) DeprecationWarning: deepEqual() is deprecated, use same() instead
> (Use `node --trace-deprecation ...` to show where the warning was created)
> test/comment.js
>   trailing comment
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ expected to throw
> 
> test/empty.js
>   empty
> 
>     ✓ expected to not throw
> 
>   empty with standalone
> 
>     ✓ expected to not throw
> 
> (node:217185) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
> (Use `node --trace-deprecation ...` to show where the warning was created)
> (node:217185) DeprecationWarning: deepEqual() is deprecated, use same() instead
> test/not_found.js
>   not found
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ expected to throw
> 
>     ✓ should be equal
> 
> test/only_execute_entries.js
>   raw
> 
>     ✓ expect truthy value
> 
> test/order.js
>   raw
> 
>     ✓ should be equivalent
> 
> test/pack.js
>   pack
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
> test/raw.js
>   raw
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ expected to throw
> 
> test/source-maps-existing.js
>   pack one file with source file field and existing sourcemap
> 
>     ✓ first original mappings are same
> 
>     ✓ last original mappings are same
> 
>     ✓ first generated columns are same
> 
>     ✓ last generated columns are same
> 
>     ✓ first generated line is offset by 1
> 
>     ✓ last generated line is offset by 1
> 
>     ✓ removes orinal source maps
> 
> test/source-maps.js
>   pack one file with source file field and one without
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ contains source mapping url as last line
> 
>     ✓ includes mappings for sourceFile and prelude only
> 
>     ✓ adds offset mapping for each line
> 
>   pack two files with source file field
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ contains source mapping url as last line
> 
>     ✓ includes mappings for both files and prelude
> 
>     ✓ adds offset mapping for each line
> 
>   pack two files without source file field
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ contains no source mapping url
> 
>   pack two files with source file field, one with nomap flag
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ contains source mapping url as last line
> 
>     ✓ includes mappings for only the file without the "nomap" flag and prelude
> 
>     ✓ adds offset mapping for each line of mapped file
> 
>   custom sourceMapPrefix for //@
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ contains source mapping url as last line
> 
>     ✓ includes mappings for sourceFile and prelude only
> 
>     ✓ adds offset mapping for each line
> 
>   custom sourceRoot
> 
>     ✓ sets a custom source root
> 
> (node:217192) DeprecationWarning: deepEqual() is deprecated, use same() instead
> (Use `node --trace-deprecation ...` to show where the warning was created)
> test/this.js
>   this
> 
>     ✓ should be equivalent
> 
> test/unicode.js
>   unicode
> 
>     ✓ expect truthy value
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ should be equal
> 
>     ✓ expected to throw
> 
> 
>   71 passing (2s)
> ERROR: Coverage for lines (95.31%) does not meet global threshold (100%)
> ERROR: Coverage for branches (94.44%) does not meet global threshold (100%)
> ERROR: Coverage for statements (94.36%) does not meet global threshold (100%)
> ----------|---------|----------|---------|---------|-------------------
> File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
> ----------|---------|----------|---------|---------|-------------------
> All files |   94.36 |    94.44 |     100 |   95.31 |                   
>  index.js |   94.36 |    94.44 |     100 |   95.31 | 47-48,105         
> ----------|---------|----------|---------|---------|-------------------
> dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 1


The full build log is available from:
http://qa-logs.debian.net/2022/04/12/node-browser-pack_6.1.0+ds+~6.1.1-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220412;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220412&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.