[Pkg-javascript-devel] Bug#1004471: Fwd: node-terser_5.15.0-1_source.changes ACCEPTED into unstable

[Yadd]

On 29/08/2022 18:24, Jonas Smedegaard wrote:
> Quoting Yadd (2022-08-29 17:16:58)
>> On 29/08/2022 16:46, Jonas Smedegaard wrote:
>>> a) Why is patch 2001 still needed?  You kept parts of if despite terser
>>> now being v5.  Yes, testsuite fails without that patch but I don't
>>> understand why (suspect the cause being newer-than-expected jest).
>>
>> yes this patch should be renamed. The part I kept wasn't related to
>> terser 5 but something else. This seems not be related to jest (existed
>> before jest update). I'll search from where comes this error
> 
> Thanks.
> 
> Do you mean within hours, or better that I file a bugreport to track
> this?
> 
> Don't mean to rush you (and fixing this is not urgent), just don't want
> to bother with a bugreport if you are as swift as commonly :-)

Sadly it's an upstream issue, snapshot changed (maybe with Node.js 
update): even with a `npm install && ./node_modules/.bin/jest 
test/test.js`, the same snapshot change is needed.

Test based on snapshots are often annoying since they generate 
false-positive regressions. You can replace this patch by a call to 
`jest -u`

Cheers,
Yadd