[Pkg-javascript-devel] Bug#1005294: Bug#1005294: Emscripten attempts to run invalid closure-compiler command

[Jonas Smedegaard]

Quoting Jeremy James (2022-02-11 14:59:06)
> I would suggest updating the arguably faulty patch to just have the
> following for tools/building.py's get_closure_compiler() (optionally
> fixing the upstream comment typo):
> --
> def get_closure_compiler():
>   # First check if the user configured a specific CLOSURE_COMPILER in
> thier settings
>   if config.CLOSURE_COMPILER:
>     return config.CLOSURE_COMPILER
> 
>   # Otherwise use the system-shared one
>   return ['closure-compiler']
> --
> And then it would actually call closure-compiler and it might just
> inspire somebody more au fait with the respective packages (and how to
> approach such a problem) to address the 16 or so reverse-dependencies
> of closure-compiler mentioned in #916145?

Makes sense now.  Thanks for elaborating!

I think a better approach is to simply set CLOSURE_COMPILER by default 
and (build-)depend on closure-compiler.

Please consider sharing if you write a closure-compiler wrapper script - 
might be sensible to ship with emscripten package, e.g. by setting 
CLOSURE_COMPILER=/usr/share/emscripten/closure-compiler_wrapper by 
default.

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20220211/e607787a/attachment.sig>