[Pkg-javascript-devel] RFS: node-esprima

[Yadd]

On 16/02/2022 09:24, Caleb Adepitan wrote:
> 
> 
> On 2/16/22 6:16 AM, Yadd wrote:
>> On 15/02/2022 18:44, Caleb Adepitan wrote:
>>> Hello,
>>>
>>> I just updated node-esprima which was some time ago reported to have 
>>> failed build with webpack 5. We've fixed issue with webpack 5 and 
>>> I've also updated node-esprima as needed.
>>>
>>> I've made sure it builds successfully and passes tests including 
>>> autopkgtest tests.
>>>
>>> Here is the repo that has the changes: 
>>> https://salsa.debian.org/calebpitan/node-esprima
>>>
>>> I'd love to request for sponsorship and uploading.
>>>
>>> Thanks,
>>>
>>> Caleb Adepitan.
>>
>> Here is the changelog.
>>   * first: 4.0.1+ds+~4.0.3-3 wasn't pushed (to NEW)
> So should I keep this version rather than bumping the revision to 4?
> 
>>   * second: I don't see any change related to webpack5
> Turns out node-esprima wasn't buggy. It was webpack 5 all along, so 
> node-esprima doesn't need any changes related to webpack 5 as it builds 
> fine. The only problem with node-esprima was the missing files which I 
> tried adding to debian/node-esprima.install.

Problem exists only on non published version. unstable published all files:

$ dpkg -L node-esprima
/.
/usr
/usr/bin
/usr/share
/usr/share/doc
/usr/share/doc/node-esprima
/usr/share/doc/node-esprima/README.md
/usr/share/doc/node-esprima/changelog.Debian.gz
/usr/share/doc/node-esprima/changelog.gz
/usr/share/doc/node-esprima/copyright
/usr/share/javascript
/usr/share/javascript/esprima
/usr/share/javascript/esprima/esprima.js
/usr/share/man
/usr/share/man/man1
/usr/share/man/man1/esparse.1.gz
/usr/share/man/man1/esvalidate.1.gz
/usr/share/nodejs
/usr/share/nodejs/@types
/usr/share/nodejs/@types/esprima
/usr/share/nodejs/@types/esprima/index.d.ts
/usr/share/nodejs/@types/esprima/package.json
/usr/share/nodejs/esprima
/usr/share/nodejs/esprima/bin
/usr/share/nodejs/esprima/bin/esparse.js
/usr/share/nodejs/esprima/bin/esvalidate.js
/usr/share/nodejs/esprima/package.json
/usr/share/nodejs/esprima/src
/usr/share/nodejs/esprima/src/assert.js
/usr/share/nodejs/esprima/src/character.js
/usr/share/nodejs/esprima/src/comment-handler.js
/usr/share/nodejs/esprima/src/error-handler.js
/usr/share/nodejs/esprima/src/esprima.js
/usr/share/nodejs/esprima/src/jsx-nodes.js
/usr/share/nodejs/esprima/src/jsx-parser.js
/usr/share/nodejs/esprima/src/jsx-syntax.js
/usr/share/nodejs/esprima/src/messages.js
/usr/share/nodejs/esprima/src/nodes.js
/usr/share/nodejs/esprima/src/parser.js
/usr/share/nodejs/esprima/src/scanner.js
/usr/share/nodejs/esprima/src/syntax.js
/usr/share/nodejs/esprima/src/token.js
/usr/share/nodejs/esprima/src/tokenizer.js
/usr/share/nodejs/esprima/src/xhtml-entities.js
/usr/bin/esparse
/usr/bin/esvalidate
/usr/share/nodejs/esprima/dist

> Do you think I should report the missing files as a bug in node-esprima, 
> probably for historical purpose, although this changes fixes it?

No, just fix it in salsa.d.o/js-team/node-esprima. Note that your 
debian/install was wrong, use mine