[Pkg-javascript-devel] Bug#1005872: node-istanbul: Remove libjs-prettify dependency

[Vignesh Raman]

Package: node-istanbul
Version: 0.4.5+ds+~cs56.14.45-1
Severity: normal
Tags: patch
X-Debbugs-Cc: vignesh.raman at collabora.com

Dear Maintainer,

prettify.js is unmaintanined https://github.com/googlearchive/code-prettify.
node-istanbul has vendored copy of prettify.js and it can that instead of
prettify.js,

Attached is a patch to remove dependency on libjs-prettify and to use
the vendor provided prettify.js. Please let me know
you opinion on this. Thanks.

Regards,
Vignesh

-- System Information:
Debian Release: 11.1
  APT prefers stable
  APT policy: (700, 'stable'), (650, 'testing'), (600, 'unstable'), (500, 'stable-updates'), (500, 'stable-security')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-9-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_IN, LC_CTYPE=en_IN (charmap=UTF-8), LANGUAGE=en_IN:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages node-istanbul depends on:
pn  handlebars            <none>
pn  libjs-prettify        <none>
pn  node-abbrev           <none>
pn  node-archy            <none>
pn  node-async            <none>
pn  node-escodegen        <none>
pn  node-esprima          <none>
pn  node-glob             <none>
pn  node-is-stream        <none>
pn  node-js-yaml          <none>
pn  node-make-dir         <none>
pn  node-mkdirp           <none>
pn  node-nopt             <none>
pn  node-once             <none>
pn  node-p-map            <none>
pn  node-path-key         <none>
pn  node-resolve          <none>
pn  node-rimraf           <none>
pn  node-shebang-command  <none>
pn  node-strip-bom        <none>
pn  node-supports-color   <none>
pn  node-type-fest        <none>
pn  node-uuid             <none>
pn  node-which            <none>
pn  node-wordwrap         <none>
pn  nodejs                <none>

Versions of packages node-istanbul recommends:
pn  node-babel7        <none>
pn  node-resolve-from  <none>

node-istanbul suggests no packages.
-------------- next part --------------
>From a6107a79874aea0ad7d985ee11b795670eb03886 Mon Sep 17 00:00:00 2001
From: Vignesh Raman <vignesh.raman at collabora.com>
Date: Mon, 14 Feb 2022 19:42:18 +0530
Subject: [PATCH] Remove libjs-prettify dependency

Instead of using the unmaintained prettify.js from
https://github.com/googlearchive/code-prettify, use
the vendored prettify.js and remove the libjs-prettify
dependency.

Signed-off-by: Vignesh Raman <vignesh.raman at collabora.com>
---
 debian/control      | 2 --
 debian/nodejs/links | 6 ++----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/debian/control b/debian/control
index 8cf1c0a..87e6eab 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,6 @@ Build-Depends:
  , dh-buildinfo
  , dh-sequence-nodejs
  , handlebars <!nocheck>
- , libjs-prettify
  , node-abbrev <!nocheck>
  , node-async <!nocheck>
  , node-babel7 <!nocheck>
@@ -38,7 +37,6 @@ Architecture: all
 Depends:
  ${misc:Depends}
  , handlebars
- , libjs-prettify
  , node-abbrev
  , node-async
  , node-escodegen
diff --git a/debian/nodejs/links b/debian/nodejs/links
index b7773cb..ba51f32 100644
--- a/debian/nodejs/links
+++ b/debian/nodejs/links
@@ -1,5 +1,3 @@
-/usr/share/javascript/prettify/prettify.css istanbul/lib/assets/vendor/prettify.css
-/usr/share/javascript/prettify/prettify.js  istanbul/lib/assets/vendor/prettify.js
-/usr/share/javascript/prettify/prettify.css istanbul-reports/lib/html/assets/vendor/prettify.css
-/usr/share/javascript/prettify/prettify.js  istanbul-reports/lib/html/assets/vendor/prettify.js
+/usr/share/nodejs/istanbul-reports/lib/html/assets/vendor/prettify.css istanbul/lib/assets/vendor/prettify.css
+/usr/share/nodejs/istanbul-reports/lib/html/assets/vendor/prettify.js istanbul/lib/assets/vendor/prettify.js
 istanbul/lib/cli.js /usr/bin/istanbul
-- 
2.30.2