[Pkg-javascript-devel] RFH: puppeteer tests

[Andrius Merkys]

Hi Yadd,

Thanks a lot for your help!

I see you have updated puppeteer to v13.0.1. Martina and I have
attempted to stick to earlier versions, but if you had luck building
v13.0.1, IMO this is even better.

On 2022-01-14 10:41, Yadd wrote:
> I started to modify your package. The problem for tests is that it
> launches chromium, then this requires X server.

Have you tried xvfb? Most of the time it works for me.

On 2022-01-14 11:18, Yadd wrote:
> and package needs a local chrome (not chromium), automatically
> downloaded during `npm install`

That is what I feared. However, README.md talks about chromium as well,
and firefox seem to have been supported at some stage. As for downloads,
I saw there was a mention of puppeteer-core which attempts to use
as-installed browsers, but I admit I did not do a deep research there.

On 2022-01-14 11:25, Yadd wrote:
> I disabled also the minimal test you put on debian/tests/pkg-js/test: it
> requires network (launches npm view). You should rewrite it in shell
> script (it just compare chrome version to what is set in its
> package.json and node-devtools-protocol version)

Right, I disabled the same test in commit
c28ad891ecd88b517565b03e94d1d1818baf4fdc of 'run-tests' branch.

Thanks once more,
Andrius