[Pkg-javascript-devel] Bug#988507: help needed to prepare upgrade of terser

[Pirate Praveen]

On Sun, 06 Feb 2022 12:26:08 +0100 Jonas Smedegaard <dr at jones.dk> wrote:
 > One known blocker for upgrading terser is that the executable has
 > changed name.  I should have adjusted all packages in the Javascript
 > team and filed bugreports against packages outside the team, and now 
in
 > theory all packages should succesfully build with terser v4.8 
available
 > in experimental.
 >
 > Next step in upgrading terser to v4.8 is to test if that theory holds
 > true.  I have not found time for testing that for some time, and also
 > don't have the experience in that task so I guess others in the team 
are
 > more efficient in doing it than me.
 >
 > So consider this an invitation to help modernizing terser package:
 >
 >  1.  Test-build all reverse-build-dependencies of terser
 >      in a build environment with experimental terser 4.8.0-1 
installed
 >  2a. if many builds fail, report that to 988507 at bugs.debian.org
 >  2b. if few builds fail, file bugreport against those packages
 >  3.  report summary of tests made to 988507 at bugs.debian.org

Ruby team has automated scripts for doing this.
https://salsa.debian.org/ruby-team/meta

setup script creates chroots for sbuild and lxc and then build script 
prompts if we should test (rebuild using sbuild and autopkgtest using 
lxc or schroot) any reverse (build) dependencies. We can choose the 
list of packages to test and it will give a report after testing all 
the selected packages.

I have been using this for all major updates (for ruby as well as js 
packages) and I highly recommend using these scripts. I think Jeremy 
also has something similar using gitlab ci, created for nodejs 
rebuilds. We will have to provide a custom gitlab runner machine for 
that I think (as salsa ci default runners don't support such mass 
rebuilds).

While running this I noticed this autopkgtest error (fails also on 
ci.debian.net). This probably needs an autopkgtest dependency on nodejs.

autopkgtest [15:56:55]: test command1: node -e "require('terser');"
autopkgtest [15:56:55]: test command1: [-----------------------
bash: line 1: node: command not found
autopkgtest [15:56:55]: test command1: -----------------------]
command1 FAIL non-zero exit status 127
autopkgtest [15:56:56]: test command1: - - - - - - - - - - results - - 
- - - - - - - -
autopkgtest [15:56:56]: test command1: - - - - - - - - - - stderr - - - 
- - - - - - -
bash: line 1: node: command not found

and I have started a test of all reverse (build) dependencies,

========================================================================
= Found reverse runtime, build, or test dependencies that can be tested!
========================================================================

autopkgtest
-----------

node-rollup node-uglifyjs-webpack-plugin
node-rollup-plugin-terser ruby-terser

rebuild
-------

almond node-ipaddr.js
impress.js node-is-stream
janus node-istanbul
jquery-coolfieldset node-jmespath
jquery-lazyload node-jquery-textcomplete
jquery-reflection node-jschardet
jquery-watermark node-markdown-it
jsxgraph node-markdown-it-html5-embed
leaflet node-marked
leaflet-markercluster node-md5-hex
less.js node-mem
node-base64-js node-mermaid
node-bootstrap-switch node-prismjs
node-chai node-prop-types
node-chance node-ramda
node-chart.js node-rollup-plugin-terser
node-configstore node-shiny-server-client
node-core-js node-slice-ansi
node-create-react-class node-sockjs-client
node-d3-force node-tap
node-d3-queue node-thenby
node-dagre-d3-renderer node-timeago.js
node-dagre-layout node-ua-parser-js
node-dateformat node-uglifyjs-webpack-plugin
node-dot-prop node-uvu
node-es6-promise node-vue-resource
node-events node-wrap-ansi
node-fecha popper.js
node-find-up psl.js
node-flatted ruby-rails-assets-jquery-nicescroll
node-formidable theano
node-fuzzaldrin-plus twitter-bootstrap4
node-graphlibrary underscore
node-has-ansi vue-router.js
node-i18next-http-backend vue.js

Which tests to run: [A(all)/e(dit list)]/s(kip all)]

========================================================================
= Testing reverse (build) dependencies
========================================================================


rebuild almond ...

Once the rebuilds and autopkgtests are complete, I will report back the 
results here.