[Pkg-javascript-devel] Bug#1011816: Bug#1004471: Update node-terser to latest upstream (node-terser 5)

[Jonas Smedegaard]

[ dropping randomly one of the cross-posted bugreports ]

Quoting Yadd (2022-06-25 12:13:48)
> On 25/06/2022 12:03, Jonas Smedegaard wrote:
> > Quoting Yadd (2022-06-25 09:51:05)
> >> On 30/05/2022 13:07, Jonas Smedegaard wrote:
> > Your fixing the issues is great.  The minor issue I had with it
> > was your sharing fixes for multiple issues as a single patch, making it
> > hard to follow what exactly is going on, and consequently making it hard
> > to navigate in it - i.e. adopt only some changes but not others.
> > 
> > Concretely, I am not ready to move to terser v5 yet, and this RC bug
> > does *not* require bumping to terser v5.  Your sharing a fix for this
> > issue that goes "first upgrade to terser v5, then patch that different
> > codebase like this..." made it hard for me to change that *one line*
> > really related to this bug:
> > 
> > -+if ("ecma" in opts) {
> > ++if ("ecma" in opts && opts.ecma != undefined) {
> > 
> > Let me repeat to emphasize: I truly appreciate your work triaging bugs!
> > 
> > Just please consider making "atomic changes": One git commit (or patch
> > file) per semantic change - not multiple lesser-related changes lumped
> > together.
> 
> Thanks, usually  it seems like you prefer debdiff instead of MR, that's 
> why I did this. Would you rather I make some MRs this time?

No thanks: I dislike MRs because they put the burden on the receiver to
play along with a specific model of using git indirectly via a custom
web interface (or a custom REST interface).

But the alternative to MRs is not a debdiff, but a diff.

If it takes 7 changes to fix a bug, then share that as 7 distinct
pieces, either as a git branch somewhere containing 7 commits, or as 7
unified diff patches attached to an email.


Regards,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20220625/8503d6d3/attachment.sig>