[Pkg-javascript-devel] [RFS] node-c8

[Yadd]

On 26/06/2022 19:24, Vinay wrote:
> Hello,
> 
> Requesting sponsorship for the package node-c8 .
> 
> Current  Version: 7.11.3+dfsg-1  .
> I have made sure the package is lintian clean and build in clean chroot 
> in sbuild.
> My salsa repo : https://salsa.debian.org/vinay-keshava/node-c8
> 
> 
> Thank You,
> Vinay Keshava <vinaykeshava at disroot.org>

Hi,

* copyright:
   - missing copyright for lib/source-map-from-file.js (Expat)
* instead of overriding dh_install, simply drop debian/nodejs/links
* clean debian/changelog: only the first line is useful
* build-dependencies:
   - replace node-jest by jest
   - drop test dependency to node-istanbul (dependency of jest)
   - drop test dependency to jest: you didn't enable test because you
     dropped bin directory, why ? It is not a file with any DFSG problem
   - you also dropped some other fixture files, why ? You can override
     lintian warnings here: files are little and readable (even if
     serialized)
   - Note also that test has to be launched using mocha, not jest
   - add all dependencies into build-dependencies with <!nocheck>
* drop debian/dirs
* update debian/docs: add CONTRIBUTING.md and MAINTAINERS_GUIDE.md
* add lintian overrides (source-map lines are long):

    # Test data
    source-is-missing *test/*
    source-contains-prebuilt-javascript-object *test/*
    very-long-line-length-in-source-file *test/*