[Pkg-javascript-devel] [RFS] node-c8

[Yadd]

On 28/06/2022 08:03, Vinay wrote:
> 
> On 28/06/22 21:47, Yadd wrote:
>> On 28/06/2022 02:05, Vinay wrote:
>>>
>>> On 27/06/22 13:43, Yadd wrote:
>>>> On 26/06/2022 19:24, Vinay wrote:
>>>>> Hello,
>>>>>
>>>>> Requesting sponsorship for the package node-c8 .
>>>>>
>>>>> Current  Version: 7.11.3+dfsg-1  .
>>>>> I have made sure the package is lintian clean and build in clean 
>>>>> chroot in sbuild.
>>>>> My salsa repo : https://salsa.debian.org/vinay-keshava/node-c8
>>>>>
>>>>>
>>>>> Thank You,
>>>>> Vinay Keshava <vinaykeshava at disroot.org>
>>>>
>>>> Hi,
>>> Hello,
>>>>
>>>> * copyright:
>>>>   - missing copyright for lib/source-map-from-file.js (Expat)
>>> for the whole lib/* directory?
>>
>> No, for this specific file. It contains its own copyright
>>
>>>> * instead of overriding dh_install, simply drop debian/nodejs/links 
>>> just rm -rf debian/nodejs/links ?
>>
>> Yes, then nothing will be installed into /usr/bin
>>
>>>> * clean debian/changelog: only the first line is useful
>>>> * build-dependencies:
>>>>   - replace node-jest by jest
>>>>   - drop test dependency to node-istanbul (dependency of jest)
>>>>   - drop test dependency to jest: you didn't enable test because you
>>>>     dropped bin directory, why ? It is not a file with any DFSG problem
>>>>   - you also dropped some other fixture files, why ? You can override
>>>>     lintian warnings here: files are little and readable (even if
>>>>     serialized)
>>>>   - Note also that test has to be launched using mocha, not jest
>>>
>>> For test ,the dependency list for chai-jest-snapshot was huge so 
>>> dropped the tests
>>> https://paste.debian.net/1245478/
>>>
>>> |$ cat debian/tests/pkg-js/test |
>>>
>>> |TS_NODE_SKIP_PROJECT=true node ./bin/c8.js mocha --timeout=10000 
>>> ./test/*.js |Error: Cannot find module 'chai-jest-snapshot'
>>> ||
>>
>> Only test/integration.js needs it. Try this test:
>>
>>   mocha `ls test/*.js | grep -v test/integration`
> https://paste.debian.net/1245507/
> 
> Error: Cannot find module '@istanbuljs/schema/default-extension'
> 
> (in lib/parse-args.js and test/parse-args.js)
> 
> node-istanbuljs-schema is embedded into node-istanbul

It is:

$ dpkg -L node-istanbul|grep @istanbuljs/schema/default-extension
/usr/share/nodejs/@istanbuljs/schema/default-extension.js

Try to list @istanbuljs/schema in debian/nodejs/extlinks (with " test")