[Pkg-javascript-devel] RFS: node-ts-loader

[Israel Galadima]

Hello Yadd,

I've dropped the chalk component.

However, I noticed that when I ran node -p require('chalk') in the package
folder without the chalk component I got this chalk object

[Function: chalk] createChalk { level: 2 }

And when I ran node -p require('chalk') in the package folder with the
chalk component I got this chalk object

[Function (anonymous)] Chalk {
    constructor: [Function (anonymous)],
    Instance: [class ChalkClass],
    supportsColor: { level: 2, hasBasic: true, has256: true, has16m: false
},
    stderr: [Function (anonymous)] Chalk {
        constructor: [Function(anonymous)],
        Instance: [class ChalkClass],
        supportsColor: { level: 2, hasBasic: true, has256: true, has16m:
false }
    }
}

Both requires don't return the same chalk object.

And there are files in the package that use properties from the chalk
object returned with the chalk component. An example is in src/instances.ts

const colors = new chalk.Instance({ level });

Instance is only a property in the chalk object when we use the chalk
component. It will be unavailable if we choose to exclude the chalk
component.

On Fri, 18 Nov 2022 at 08:39, Yadd <yadd at debian.org> wrote:

> On 10/11/2022 20:47, Israel Galadima wrote:
> > Hello Debian JavaScript Team,
> >
> > I'm writing this email to request for sponsorship for a new package I
> > have worked on.
> > Here are the details of the package:
> >
> > Package Name: node-ts-loader
> > Package Version: 9.4.1
> > Debian Version: 9.4.1+~cs4.1.0
> > Package Repo: https://salsa.debian.org/izzygala/node-ts-loader
> > <https://salsa.debian.org/izzygala/node-ts-loader>
> >
> > I have built this package successfully using sbuild and it passes all
> > lintian tests except for a privacy-breach-generic warning caused by an
> > external link in an example html file installed through
> dh_installexamples.
> >
> > I have disabled tests for the package for the following reasons:
> > - It runs a comparison test against pre-built files generated on a
> > platform other than Debian. The generated files I am getting on Debian
> > look similar to but are not the same as the pre-built files. Thus, these
> > comparison tests fail
> > - It runs an execution test using packages unavailable in Debian e.g.
> karma
> >
> > Notwithstanding, I hope this package can get sponsored. It is a
> > dependency of the yarn-apt plugin created during the last Outreachy
> > round. Thank you for your time.
>
> Hi,
>
> please drop chalk component: typescript definitions in
> debian/build_modules are enough here
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20221120/af3f7317/attachment.htm>