[Pkg-javascript-devel] Bug#1033866: unblock: node-sockjs-client/1.6.1+dfsg1-2

Yadd yadd at debian.org
Mon Apr 3 07:48:08 BST 2023


Package: release.debian.org
Severity: normal
User: release.debian.org at packages.debian.org
Usertags: unblock
X-Debbugs-Cc: node-sockjs-client at packages.debian.org
Control: affects -1 + src:node-sockjs-client

Please unblock package node-sockjs-client

[ Reason ]
autopkgtest is broken due to a __proto__ access which is now forbidden
during autopkgtest (pkg-js-autopkgtest).

[ Impact ]
No impact, no code change

[ Tests ]
Test passed (both build & autopkgtest)

[ Risks ]
No risk, no code change

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]
This change includes a lintian-brush fix (little things in lintian +
policy 4.6.2)

Regards,
Yadd

unblock node-sockjs-client/1.6.1+dfsg1-2
-------------- next part --------------
diff --git a/debian/changelog b/debian/changelog
index d68db9b..77c59b4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,18 @@
+node-sockjs-client (1.6.1+dfsg1-2) unstable; urgency=medium
+
+  * Team upload
+
+  [ lintian-brush ]
+  * Update lintian override info format in d/source/lintian-overrides
+    on line 2-8, 11-27
+  * Use secure URI in Homepage field
+  * Update standards version to 4.6.2, no changes needed
+
+  [ Yadd ]
+  * Drop __proto__ calls in tests (Closes: #1033821)
+
+ -- Yadd <yadd at debian.org>  Mon, 03 Apr 2023 10:13:25 +0400
+
 node-sockjs-client (1.6.1+dfsg1-1) unstable; urgency=medium
 
   * Team upload
diff --git a/debian/control b/debian/control
index 811e9fc..809ccdc 100644
--- a/debian/control
+++ b/debian/control
@@ -22,10 +22,10 @@ Build-Depends:
  , node-proxyquire <!nocheck>
  , node-serve-static <!nocheck>
  , node-uuid <!nocheck>
-Standards-Version: 4.6.1
+Standards-Version: 4.6.2
 Vcs-Browser: https://salsa.debian.org/js-team/node-sockjs-client
 Vcs-Git: https://salsa.debian.org/js-team/node-sockjs-client.git
-Homepage: http://sockjs.org
+Homepage: https://sockjs.org
 Rules-Requires-Root: no
 
 Package: node-sockjs-client
diff --git a/debian/source/lintian-overrides b/debian/source/lintian-overrides
index 2f1b0b2..a846c89 100644
--- a/debian/source/lintian-overrides
+++ b/debian/source/lintian-overrides
@@ -1,27 +1,27 @@
 # false positive
-node-sockjs-client source: source-is-missing lib/utils/escape.js
-node-sockjs-client source: source-is-missing tests/lib/echo-tests.js
-source-contains-prebuilt-javascript-object lib/utils/escape.js
-source-contains-prebuilt-javascript-object tests/lib/echo-tests.js
-very-long-line-length-in-source-file lib/utils/escape.js line *
-very-long-line-length-in-source-file tests/lib/echo-tests.js line *
-very-long-line-length-in-source-file *.md line *
+node-sockjs-client source: source-is-missing [lib/utils/escape.js]
+node-sockjs-client source: source-is-missing [tests/lib/echo-tests.js]
+source-contains-prebuilt-javascript-object [lib/utils/escape.js]
+source-contains-prebuilt-javascript-object [tests/lib/echo-tests.js]
+very-long-line-length-in-source-file * [lib/utils/escape.js:*]
+very-long-line-length-in-source-file * [tests/lib/echo-tests.js:*]
+very-long-line-length-in-source-file * [*.md:*]
 
 # False positive in test module
-source-is-missing debian/tests/test_modules/sockjs/lib/iframe.js
-source-is-missing debian/tests/test_modules/sockjs/lib/sockjs.js
-source-is-missing debian/tests/test_modules/sockjs/lib/trans-eventsource.js
-source-is-missing debian/tests/test_modules/sockjs/lib/trans-htmlfile.js
-source-is-missing debian/tests/test_modules/sockjs/lib/trans-jsonp.js
-source-is-missing debian/tests/test_modules/sockjs/lib/trans-websocket.js
-source-is-missing debian/tests/test_modules/sockjs/lib/trans-xhr.js
-source-is-missing debian/tests/test_modules/sockjs/lib/transport.js
-source-contains-prebuilt-javascript-object debian/tests/test_modules/sockjs/lib/iframe.js
-source-contains-prebuilt-javascript-object debian/tests/test_modules/sockjs/lib/sockjs.js
-source-contains-prebuilt-javascript-object debian/tests/test_modules/sockjs/lib/trans-eventsource.js
-source-contains-prebuilt-javascript-object debian/tests/test_modules/sockjs/lib/trans-htmlfile.js
-source-contains-prebuilt-javascript-object debian/tests/test_modules/sockjs/lib/trans-jsonp.js
-source-contains-prebuilt-javascript-object debian/tests/test_modules/sockjs/lib/trans-websocket.js
-source-contains-prebuilt-javascript-object debian/tests/test_modules/sockjs/lib/trans-xhr.js
-source-contains-prebuilt-javascript-object debian/tests/test_modules/sockjs/lib/transport.js
-very-long-line-length-in-source-file debian/tests/test_modules/sockjs/lib/sockjs.js line 122 is 675 characters long (>512)
+source-is-missing [debian/tests/test_modules/sockjs/lib/iframe.js]
+source-is-missing [debian/tests/test_modules/sockjs/lib/sockjs.js]
+source-is-missing [debian/tests/test_modules/sockjs/lib/trans-eventsource.js]
+source-is-missing [debian/tests/test_modules/sockjs/lib/trans-htmlfile.js]
+source-is-missing [debian/tests/test_modules/sockjs/lib/trans-jsonp.js]
+source-is-missing [debian/tests/test_modules/sockjs/lib/trans-websocket.js]
+source-is-missing [debian/tests/test_modules/sockjs/lib/trans-xhr.js]
+source-is-missing [debian/tests/test_modules/sockjs/lib/transport.js]
+source-contains-prebuilt-javascript-object [debian/tests/test_modules/sockjs/lib/iframe.js]
+source-contains-prebuilt-javascript-object [debian/tests/test_modules/sockjs/lib/sockjs.js]
+source-contains-prebuilt-javascript-object [debian/tests/test_modules/sockjs/lib/trans-eventsource.js]
+source-contains-prebuilt-javascript-object [debian/tests/test_modules/sockjs/lib/trans-htmlfile.js]
+source-contains-prebuilt-javascript-object [debian/tests/test_modules/sockjs/lib/trans-jsonp.js]
+source-contains-prebuilt-javascript-object [debian/tests/test_modules/sockjs/lib/trans-websocket.js]
+source-contains-prebuilt-javascript-object [debian/tests/test_modules/sockjs/lib/trans-xhr.js]
+source-contains-prebuilt-javascript-object [debian/tests/test_modules/sockjs/lib/transport.js]
+very-long-line-length-in-source-file 675 > 512 [debian/tests/test_modules/sockjs/lib/sockjs.js:122]
diff --git a/debian/tests/test_modules/sockjs/lib/trans-jsonp.js b/debian/tests/test_modules/sockjs/lib/trans-jsonp.js
index 5e807ea..5cce427 100644
--- a/debian/tests/test_modules/sockjs/lib/trans-jsonp.js
+++ b/debian/tests/test_modules/sockjs/lib/trans-jsonp.js
@@ -80,7 +80,7 @@
           };
         }
       }
-      if (!d || d.__proto__.constructor !== Array) {
+      if (!d || Object.getPrototypeOf(d).constructor !== Array) {
         throw {
           status: 500,
           message: 'Payload expected.'
diff --git a/debian/tests/test_modules/sockjs/lib/trans-xhr.js b/debian/tests/test_modules/sockjs/lib/trans-xhr.js
index 3825095..80ccd10 100644
--- a/debian/tests/test_modules/sockjs/lib/trans-xhr.js
+++ b/debian/tests/test_modules/sockjs/lib/trans-xhr.js
@@ -64,7 +64,7 @@
           message: 'Broken JSON encoding.'
         };
       }
-      if (!d || d.__proto__.constructor !== Array) {
+      if (!d || Object.getPrototypeOf(d).constructor !== Array) {
         throw {
           status: 500,
           message: 'Payload expected.'


More information about the Pkg-javascript-devel mailing list