[Pkg-javascript-devel] Bug#1047677: node-https-proxy-agent: Fails to build source after successful build

[Lucas Nussbaum]

Source: node-https-proxy-agent
Version: 5.0.1+~cs8.0.0-3
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package node-https-proxy-agent
> dpkg-buildpackage: info: source version 5.0.1+~cs8.0.0-3
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jelmer Vernooij <jelmer at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean --buildsystem=nodejs
> 	rm -rf ./node_modules/.cache ./.nyc_output
> 	rm -rf http-proxy-agent/node_modules/.cache http-proxy-agent/.nyc_output
> 	rm -rf tootallnate-once/node_modules/.cache tootallnate-once/.nyc_output
> rm ./node_modules/.cache
> unlink ./node_modules/@types/events
> Trying to remove ./node_modules/@types
> unlink ./node_modules/@types/ms
> Trying to remove ./node_modules/@types
> unlink ./node_modules/@types/node
> Trying to remove ./node_modules/@types
> rm ./node_modules/agent-base
> rm ./node_modules/@types/debug
> Trying to remove ./node_modules/@types
> rm http-proxy-agent/node_modules/.cache
> rm tootallnate-once/node_modules/.cache
> unlink http-proxy-agent/node_modules/@tootallnate/once
> unlink node_modules/http-proxy-agent
> unlink node_modules/@tootallnate/once
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building node-https-proxy-agent using existing ./node-https-proxy-agent_5.0.1+~cs8.0.0.orig-http-proxy-agent.tar.gz
> dpkg-source: info: building node-https-proxy-agent using existing ./node-https-proxy-agent_5.0.1+~cs8.0.0.orig-tootallnate-once.tar.gz
> dpkg-source: info: building node-https-proxy-agent using existing ./node-https-proxy-agent_5.0.1+~cs8.0.0.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  node-https-proxy-agent-5.0.1+~cs8.0.0/http-proxy-agent/test/ssl-cert-snakeoil.key
>  node-https-proxy-agent-5.0.1+~cs8.0.0/http-proxy-agent/test/ssl-cert-snakeoil.pem
>  node-https-proxy-agent-5.0.1+~cs8.0.0/test/ssl-cert-snakeoil.key
>  node-https-proxy-agent-5.0.1+~cs8.0.0/test/ssl-cert-snakeoil.pem
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/node-https-proxy-agent_5.0.1+~cs8.0.0-3.diff.NoIh9l
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/node-https-proxy-agent_5.0.1+~cs8.0.0-3_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.