[Pkg-javascript-devel] Bug#1048460: node-eslint-visitor-keys: Fails to build source after successful build

[Lucas Nussbaum]

Source: node-eslint-visitor-keys
Version: 3.3.0+~1.0.0-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package node-eslint-visitor-keys
> dpkg-buildpackage: info: source version 3.3.0+~1.0.0-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jonas Smedegaard <dr at jones.dk>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    debian/rules override_dh_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_clean -- README.html README.txt CHANGELOG.html CHANGELOG.txt
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building node-eslint-visitor-keys using existing ./node-eslint-visitor-keys_3.3.0+~1.0.0.orig-Xtypes.tar.gz
> dpkg-source: info: building node-eslint-visitor-keys using existing ./node-eslint-visitor-keys_3.3.0+~1.0.0.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: file node-eslint-visitor-keys-3.3.0+~1.0.0/dist/eslint-visitor-keys.cjs.map has no final newline (either original or modified version)
> dpkg-source: warning: file node-eslint-visitor-keys-3.3.0+~1.0.0/dist/index.d.ts has no final newline (either original or modified version)
> dpkg-source: warning: file node-eslint-visitor-keys-3.3.0+~1.0.0/dist/index.d.ts.map has no final newline (either original or modified version)
> dpkg-source: warning: file node-eslint-visitor-keys-3.3.0+~1.0.0/dist/visitor-keys.d.ts has no final newline (either original or modified version)
> dpkg-source: warning: file node-eslint-visitor-keys-3.3.0+~1.0.0/dist/visitor-keys.d.ts.map has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  node-eslint-visitor-keys-3.3.0+~1.0.0/dist/eslint-visitor-keys.cjs
>  node-eslint-visitor-keys-3.3.0+~1.0.0/dist/eslint-visitor-keys.cjs.map
>  node-eslint-visitor-keys-3.3.0+~1.0.0/dist/index.d.ts
>  node-eslint-visitor-keys-3.3.0+~1.0.0/dist/index.d.ts.map
>  node-eslint-visitor-keys-3.3.0+~1.0.0/dist/visitor-keys.d.ts
>  node-eslint-visitor-keys-3.3.0+~1.0.0/dist/visitor-keys.d.ts.map
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/node-eslint-visitor-keys_3.3.0+~1.0.0-1.diff.7XGWtO
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/node-eslint-visitor-keys_3.3.0+~1.0.0-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.