[Pkg-javascript-devel] Bug#1048682: node-fortawesome-fontawesome-free: Fails to build source after successful build

[Lucas Nussbaum]

Source: node-fortawesome-fontawesome-free
Version: 6.4.0+ds1-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package node-fortawesome-fontawesome-free
> dpkg-buildpackage: info: source version 6.4.0+ds1-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Yadd <yadd at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean --buildsystem=nodejs
> /!\ ./package.json not found
> Found debian/nodejs/additional_components
> Adding component(s): js-packages/@fortawesome/fontawesome-common-types, js-packages/@fortawesome/fontawesome-free, js-packages/@fortawesome/fontawesome-svg-core, js-packages/@fortawesome/free-brands-svg-icons, js-packages/@fortawesome/free-regular-svg-icons, js-packages/@fortawesome/free-solid-svg-icons
> 	rm -rf js-packages/\@fortawesome/fontawesome-free/node_modules/.cache js-packages/\@fortawesome/fontawesome-free/.nyc_output
> 	rm -rf js-packages/\@fortawesome/fontawesome-common-types/node_modules/.cache js-packages/\@fortawesome/fontawesome-common-types/.nyc_output
> 	rm -rf js-packages/\@fortawesome/fontawesome-svg-core/node_modules/.cache js-packages/\@fortawesome/fontawesome-svg-core/.nyc_output
> 	rm -rf js-packages/\@fortawesome/free-brands-svg-icons/node_modules/.cache js-packages/\@fortawesome/free-brands-svg-icons/.nyc_output
> 	rm -rf js-packages/\@fortawesome/free-regular-svg-icons/node_modules/.cache js-packages/\@fortawesome/free-regular-svg-icons/.nyc_output
> 	rm -rf js-packages/\@fortawesome/free-solid-svg-icons/node_modules/.cache js-packages/\@fortawesome/free-solid-svg-icons/.nyc_output
> Found debian/nodejs/additional_components
> Adding component(s): js-packages/@fortawesome/fontawesome-common-types, js-packages/@fortawesome/fontawesome-free, js-packages/@fortawesome/fontawesome-svg-core, js-packages/@fortawesome/free-brands-svg-icons, js-packages/@fortawesome/free-regular-svg-icons, js-packages/@fortawesome/free-solid-svg-icons
> rm js-packages/@fortawesome/fontawesome-free/node_modules/.cache
> rm js-packages/@fortawesome/fontawesome-common-types/node_modules/.cache
> rm js-packages/@fortawesome/fontawesome-svg-core/node_modules/.cache
> rm js-packages/@fortawesome/free-brands-svg-icons/node_modules/.cache
> rm js-packages/@fortawesome/free-regular-svg-icons/node_modules/.cache
> rm js-packages/@fortawesome/free-solid-svg-icons/node_modules/.cache
> Found debian/nodejs/additional_components
> Adding component(s): js-packages/@fortawesome/fontawesome-common-types, js-packages/@fortawesome/fontawesome-free, js-packages/@fortawesome/fontawesome-svg-core, js-packages/@fortawesome/free-brands-svg-icons, js-packages/@fortawesome/free-regular-svg-icons, js-packages/@fortawesome/free-solid-svg-icons
> unlink node_modules/@fortawesome/fontawesome-common-types
> unlink node_modules/@fortawesome/fontawesome-svg-core
> unlink node_modules/@fortawesome/free-brands-svg-icons
> unlink node_modules/@fortawesome/free-regular-svg-icons
> unlink node_modules/@fortawesome/free-solid-svg-icons
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building node-fortawesome-fontawesome-free using existing ./node-fortawesome-fontawesome-free_6.4.0+ds1.orig.tar.xz
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/all.min.css has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/brands.min.css has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/fontawesome.min.css has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/regular.min.css has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/solid.min.css has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/svg-with-js.min.css has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/v4-font-face.min.css has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/v4-shims.min.css has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/v5-font-face.min.css has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/all.min.js has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/brands.min.js has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/conflict-detection.min.js has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/fontawesome.min.js has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/regular.min.js has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/solid.min.js has no final newline (either original or modified version)
> dpkg-source: warning: file node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/v4-shims.min.js has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/all.min.css
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/brands.min.css
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/fontawesome.min.css
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/regular.min.css
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/solid.min.css
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/svg-with-js.min.css
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/v4-font-face.min.css
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/v4-shims.min.css
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/css/v5-font-face.min.css
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/all.min.js
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/brands.min.js
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/conflict-detection.min.js
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/fontawesome.min.js
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/regular.min.js
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/solid.min.js
>  node-fortawesome-fontawesome-free-6.4.0+ds1/js-packages/@fortawesome/fontawesome-free/js/v4-shims.min.js
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/node-fortawesome-fontawesome-free_6.4.0+ds1-2.diff.Mg8xTW
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/node-fortawesome-fontawesome-free_6.4.0+ds1-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.