[Pkg-javascript-devel] Bug#1049652: node-babel-plugin-lodash: Fails to build binary packages again after successful build

[Lucas Nussbaum]

Source: node-babel-plugin-lodash
Version: 3.3.4+~cs2.0.1-6
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-binary-20230816 ftbfs-binary-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to do build a binary-only build (not source) after a
successful build (dpkg-buildpackage ; dpkg-buildpackage -b).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/DoubleBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -b
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package node-babel-plugin-lodash
> dpkg-buildpackage: info: source version 3.3.4+~cs2.0.1-6
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Yadd <yadd at debian.org>
>  dpkg-source --before-build .
> dpkg-buildpackage: info: host architecture amd64
>  debian/rules clean
> dh clean
>    dh_auto_clean --buildsystem=nodejs
> 	rm -rf ./node_modules/.cache ./.nyc_output
> 	rm -rf require-package-name/node_modules/.cache require-package-name/.nyc_output
> rm ./node_modules/.cache
> rm require-package-name/node_modules/.cache
> unlink node_modules/require-package-name
>    dh_clean
>  debian/rules binary
> dh binary
>    dh_update_autotools_config
>    dh_autoreconf
>    dh_auto_configure --buildsystem=nodejs
> Link node_modules/require-package-name -> ../require-package-name
>    dh_auto_build --buildsystem=nodejs
> No build command found, searching known files
> Found debian/nodejs/./build
> 	cd ./. && sh -ex debian/nodejs/./build
> + rollup src/index.js -f cjs -o lib/index.js
> 
> src/index.js → lib/index.js...
> (!) Unresolved dependencies
> https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency
> lodash (imported by "src/index.js", "src/config.js", "src/importModule.js", "src/Store.js", "src/MapCache.js", "src/ModuleCache.js", "src/util.js" and "src/Package.js")
>  at babel/types (imported by "src/index.js")
>  at babel/helper-module-imports (imported by "src/importModule.js")
> fs (imported by "src/ModuleCache.js")
> glob (imported by "src/ModuleCache.js")
> module (imported by "src/ModuleCache.js")
> path (imported by "src/ModuleCache.js")
> require-package-name (imported by "src/Package.js")
> created lib/index.js in 198ms
> + mkdir -p node_modules
> + ln -s .. node_modules/babel-plugin-lodash
> + babeljs src --out-dir lib
> Successfully compiled 10 files with Babel (1119ms).
>    dh_auto_test --buildsystem=nodejs
> 	ln -s ../debian/tests/test_modules/babel-helper-module-imports node_modules/babel-helper-module-imports
> 	ln -s ../debian/tests/test_modules/require-package-name node_modules/require-package-name
> ln: failed to create symbolic link 'node_modules/require-package-name/require-package-name': File exists
> dh_auto_test: error: ln -s ../debian/tests/test_modules/require-package-name node_modules/require-package-name returned exit code 1
> make: *** [debian/rules:8: binary] Error 25
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -b' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/16/node-babel-plugin-lodash_3.3.4+~cs2.0.1-6_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.