[Pkg-javascript-devel] RFS -node-benchmark

[Yadd]

On 1/5/23 00:07, Sandra Uwah wrote:
> Hello,
> 
> I have made the changes, hope it’s in line with what you mean?

No, you dropped Mathias Bynens. Please do this:

--- a/debian/copyright
+++ b/debian/copyright
@@ -4,9 +4,10 @@ Upstream-Contact: 
https://github.com/bestiejs/benchmark.js/issues
  Source: https://benchmarkjs.com/

  Files: *
-Copyright: Robert Kieffer <http://broofa.com/>,
- modified by John-David Dalton <http://allyoucanleet.com/>
+Copyright: 2010-2016 Mathias Bynens <https://mathiasbynens.be/>
  License: Expat
+Comment: based on JSLitmus.js, copyright Robert Kieffer 
<http://broofa.com/>,
+ modified by John-David Dalton <http://allyoucanleet.com/>

  Files: debian/*
  Copyright: 2022, sandra uwah <sandrauwah282 at gmail.com>


> Best wishes.
> 
> Sandra
> 
> Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for Windows
> 
> *From: *Yadd <mailto:yadd at debian.org>
> *Sent: *Wednesday, January 4, 2023 10:09 AM
> *To: *Sandra Uwah <mailto:sandrauwah40 at gmail.com>
> *Cc: *pkg-javascript-devel 
> <mailto:pkg-javascript-devel at alioth-lists.debian.net>
> *Subject: *Re: [Pkg-javascript-devel] RFS -node-benchmark
> 
> On 1/4/23 12:58, Sandra Uwah wrote:
> 
>  > Hello,
> 
>  >
> 
>  > Requesting sponsorship for the package, node-benchmark.
> 
>  >
> 
>  > Package details:
> 
>  >
> 
>  > Package version: 2.1.4
> 
>  >
> 
>  > Package repo: https://salsa.debian.org/sandra_uwah/node-benchmark
> 
>  > <https://salsa.debian.org/sandra_uwah/node-benchmark>
> 
>  >
> 
>  > I could not enable test because the package depends on
> 
>  > quinitjs(https://www.npmjs.com/package/qunitjs
> 
>  > <https://www.npmjs.com/package/qunitjs>) which has been deprecated and
> 
>  > which also depends on another outdated package.
> 
>  >
> 
>  > Otherwise, the package is lintian clean and I have built in a clean
> 
>  > environment using sbuild. Best wishes.
> 
>  >
> 
>  > Sandra
> 
> Hi,
> 
> copyright is wrong, please add:
> 
>     Comment: Based on JSLitmus.js, copyright Robert Kieffer
> 
> <http://broofa.com/>,
> 
>      modified by John-David Dalton <http://allyoucanleet.com/>
> 
> Cheers,
> 
> Yadd
>