[Pkg-javascript-devel] Bug#1041010: Bug#1041010: Bug#1041010: Please include nbconvert-css

[Yadd]

On 7/17/23 17:06, Yadd wrote:
> On 7/17/23 16:39, Julian Gilbey wrote:
>> On Sun, Jul 16, 2023 at 03:04:26PM +0100, Julian Gilbey wrote:
>>>>> For some reason, nbconvert-css is excluded from the package.  Might it
>>>>> be possible to include it?
>>>>>
>>>>> Best wishes,
>>>>
>>>> Hi,
>>>>
>>>> I put node-jupyterlab into experimental because it's still WIP. For 
>>>> now I'm
>>>> not able to build all @jupyterlab/* components due to missing 
>>>> dependencies.
>>>> I'll continue this during autumn.
>>>
>>> Hi Yadd,
>>>
>>> Thanks for the info!  I'm taking a further look at this now and will
>>> report back when I have more information (hopefully soon).
>>> [...]
>>
>> Quick update: I managed to build @jupyterlab/nbconvert-css using just
>> a small patch to the node-jupyterlab repo on salsa.  But I'm not sure
>> if my code is "correct" (though it produces identical output to
>> upstream) - I've filed an issue upstream about this.
>> (https://github.com/webpack/webpack.js.org/issues/6969)
>>
>> When I'm happy that I've done the "right" thing, I'll file a PR
>> against jupyterlab to drop the deprecated null-loader dependency.  Are
>> you then happy for me to push the patch directly to the salsa
>> node-jupyterlab repo?
> 
> Hi,
> 
> sure you can, thanks !

I just pushed a new version with @jupyterlab/nbconvert-css (the problem 
isn't in webpack but in schema-utils transition)