[Pkg-javascript-devel] Bug#1036259: moment-timezone.js: FTBFS in testing: make[1]: *** [debian/rules:28: execute_before_dh_auto_configure] Error 1

[Martina Ferrari]

Update:

I have just uploaded the package, force-pushed my changes to master, and 
  submitted the unblock request: #1037049

On 02/06/2023 19:13, Martina Ferrari wrote:
> On Sun, 28 May 2023 18:15:14 +0200 gregor herrmann <gregoa at debian.org> 
> wrote:
>> On Sun, 28 May 2023 20:05:09 +0400, Yadd wrote:
>>
>> > > This looked reasonably easy to fix (cf. attached patch), but the
>> > > tests fail as follows:
>> > I fixed it in salsa (needs an update to import 2023 data). I'm 
>> waiting for
>> > Martina review who maintains it.
>>
>> Ack, I've seen your commits in salsa but as the pipeline fails
>> (probably the version in d/changelog?) and as a new upstream release
>> 2 weeks before the release might not be accepted by the release team,
>> I thougt I'd give it a try as well; but well, it was not that
>> quick&easy :)
> 
> Agreed. The upstream release is not much more than a repackaging of the 
> Olson database and adjusting the tests to match, but the debdiff is 
> enormous.
> 
> Luckily, the debian/rules I wrote a few years ago takes care of updating 
> the data files and tests based on the installed tzdata package (which 
> should match the last part of the debian package version).
> 
> The only thing that needs to be handled separately are the countries.js 
> test file, which is manually maintained. So I just made a quilt patch 
> based on the git diff from upstream.
> 
> I have just prepared a new package like this, the debdiff is fairly 
> minimal:
> 
> $ debdiff moment-timezone.js_0.5.40+dfsg-1+2022g.dsc 
> moment-timezone.js_0.5.40+dfsg-1+2023c.dsc | diffstat
>   changelog                     |   10 ++++++++++
>   control                       |    4 ++--
>   patches/02-tzdata-2023c.patch |   42 
> ++++++++++++++++++++++++++++++++++++++++++
>   patches/series                |    1 +
>   4 files changed, 55 insertions(+), 2 deletions(-)
> 
> Sadly, Yadd changes were already pushed to master, so I will have to do 
> some git history rewriting. Please update your local clones accordingly.
> 
> 

-- 
Martina Ferrari (Tina)