[Pkg-javascript-devel] Bug#1035805: node-source-map: copyright file missing after upgrade (policy 12.5)

[Andreas Beckmann]

Package: node-source-map
Version: 0.7.0++dfsg2+really.0.6.1-13
Severity: serious
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

a test with piuparts revealed that your package misses the copyright
file after an upgrade, which is a violation of Policy 12.5:
https://www.debian.org/doc/debian-policy/ch-docs.html#copyright-information

After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.

This was observed on the following upgrade paths:

  bullseye -> bookworm

>From the attached log (scroll to the bottom...):

0m39.3s ERROR: WARN: Inadequate results from running adequate!
  node-source-map: broken-symlink /usr/share/doc/node-source-map -> ../libjs-source-map
  node-source-map: missing-copyright-file /usr/share/doc/node-source-map/copyright
  
  MISSING COPYRIGHT FILE: /usr/share/doc/node-source-map/copyright
  # ls -lad /usr/share/doc/node-source-map
  lrwxrwxrwx 1 root root 19 May  3 22:16 /usr/share/doc/node-source-map -> ../libjs-source-map
  # ls -la /usr/share/doc/node-source-map/
  ls: cannot access '/usr/share/doc/node-source-map/': No such file or directory


Additional info may be available here:
https://wiki.debian.org/MissingCopyrightFile

Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#details-of-unpack-phase-of-installation-or-upgrade

It is recommended to use the dpkg-maintscript-helper commands
'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
to perform the conversion, ideally using d/$PACKAGE.maintscript.
See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: node-source-map_0.7.0++dfsg2+really.0.6.1-13.log.gz
Type: application/gzip
Size: 21085 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20230509/a402e92f/attachment.gz>