[Pkg-javascript-devel] Bug#1091810: node-luxon: FTBFS: FAIL test/datetime/relative.test.js Expected: "next month" Received: "next year"

[Santiago Vila]

Package: src:node-luxon
Version: 3.4.4-2
Severity: serious
Tags: ftbfs trixie sid

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

(Note: This error looks that it may happen specifically on 31 December (today),
so if you try to reproduce it tomorrow and the error disappears, please use
faketime (or equivalent) to build it "today").

--------------------------------------------------------------------------------
[...]
 debian/rules clean
dh clean
   dh_auto_clean --buildsystem=nodejs
	rm -rf ./node_modules/.cache ./.nyc_output
rm ./node_modules/.cache
rm ./node_modules/.cache
   debian/rules execute_before_dh_clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
rm -rf build
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_clean
 debian/rules binary
dh binary
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_configure --buildsystem=nodejs
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
node tasks/buildNode.js
Building node
Built node
node tasks/buildGlobal.js
Building global
Built global
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test --buildsystem=nodejs
	mkdir -p node_modules
	ln -s ../. node_modules/luxon
	/bin/sh -ex debian/tests/pkg-js/test
+ TZ=America/New_York LANG=en_US jest
PASS test/datetime/tokenParse.test.js
PASS test/datetime/create.test.js
PASS test/datetime/toFormat.test.js
PASS test/datetime/regexParse.test.js
PASS test/datetime/format.test.js
PASS test/datetime/math.test.js
PASS test/interval/many.test.js
PASS test/datetime/diff.test.js
PASS test/duration/format.test.js
PASS test/datetime/localeWeek.test.js
PASS test/datetime/zone.test.js
PASS test/duration/units.test.js
PASS test/interval/info.test.js
PASS test/datetime/set.test.js
FAIL test/datetime/relative.test.js
  ● DateTime#toRelativeCalendar picks the correct unit with no options

    expect(received).toBe(expected) // Object.is equality

    Expected: "next month"
    Received: "next year"

      122 |   const now = DateTime.now();
      123 |   const isLastDayOfMonth = now.endOf("month").day === now.day;
    > 124 |   expect(now.plus({ days: 1 }).toRelativeCalendar()).toBe(
          |                                                      ^
      125 |     isLastDayOfMonth ? "next month" : "tomorrow"
      126 |   );
      127 | });

      at Object.<anonymous> (test/datetime/relative.test.js:124:54)

PASS test/interval/format.test.js
PASS test/info/listers.test.js
PASS test/duration/math.test.js
PASS test/datetime/getters.test.js
PASS test/zones/IANA.test.js
PASS test/datetime/misc.test.js
PASS test/duration/create.test.js
PASS test/duration/parse.test.js
PASS test/interval/create.test.js
PASS test/info/zones.test.js
PASS test/zones/fixedOffset.test.js
PASS test/impl/english.test.js
PASS test/interval/parse.test.js
PASS test/datetime/dst.test.js
PASS test/duration/equality.test.js
PASS test/datetime/many.test.js
PASS test/datetime/invalid.test.js
PASS test/info/localeWeek.test.js
PASS test/duration/getters.test.js
PASS test/duration/invalid.test.js
PASS test/datetime/transform.test.js
PASS test/datetime/equality.test.js
PASS test/duration/reconfigure.test.js
PASS test/datetime/reconfigure.test.js
PASS test/duration/customMatrix.test.js
PASS test/duration/set.test.js
PASS test/duration/accuracy.test.js
PASS test/interval/localeWeek.test.js
PASS test/zones/local.test.js
PASS test/datetime/info.test.js
PASS test/duration/typecheck.test.js
PASS test/datetime/typecheck.test.js
PASS test/interval/typecheck.test.js
PASS test/interval/getters.test.js
PASS test/interval/setter.test.js
PASS test/zones/invalid.test.js
PASS test/info/features.test.js
PASS test/duration/info.test.js
PASS test/interval/proto.test.js
PASS test/datetime/degrade.test.js
PASS test/datetime/proto.test.js
PASS test/duration/proto.test.js
PASS test/zones/zoneInterface.test.js

Summary of all failing tests
FAIL test/datetime/relative.test.js
  ● DateTime#toRelativeCalendar picks the correct unit with no options

    expect(received).toBe(expected) // Object.is equality

    Expected: "next month"
    Received: "next year"

      122 |   const now = DateTime.now();
      123 |   const isLastDayOfMonth = now.endOf("month").day === now.day;
    > 124 |   expect(now.plus({ days: 1 }).toRelativeCalendar()).toBe(
          |                                                      ^
      125 |     isLastDayOfMonth ? "next month" : "tomorrow"
      126 |   );
      127 | });

      at Object.<anonymous> (test/datetime/relative.test.js:124:54)


Test Suites: 1 failed, 57 passed, 58 total
Tests:       1 failed, 1093 passed, 1094 total
Snapshots:   1 passed, 1 total
Time:        6.058 s
Ran all test suites.
dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 1
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202412/

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

Thanks.