[Pkg-javascript-devel] Bug#1076542: nodejs: autopkgtest failures

[Gianfranco Costamagna]

Source: nodejs
Version: 20.15.1+dfsg-1
Severity: serious

Hello, two tests are now failing:
https://ci.debian.net/packages/n/nodejs/testing/amd64/49188413/

  45s not ok 253 parallel/test-cli-permission-multiple-allow
  45s   ---
  45s   duration_ms: 715.29500
  45s   severity: fail
  45s   exitcode: 1
  45s   stack: |-
  45s     node:assert:126
  45s       throw new AssertionError(obj);
  45s       ^
  45s
  45s     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  45s     + actual - expected
  45s
  45s     + 'true'
  45s     - 'false'
  45s         at Object.<anonymous> (/tmp/autopkgtest-lxc.voqp2vqz/downtmp/build.4lW/src/test/parallel/test-cli-permission-multiple-allow.js:27:10)
  45s         at Module._compile (node:internal/modules/cjs/loader:1358:14)
  45s         at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
  45s         at Module.load (node:internal/modules/cjs/loader:1208:32)
  45s         at Module._load (node:internal/modules/cjs/loader:1024:12)
  45s         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
  45s         at node:internal/main/run_main_module:28:49 {
  45s       generatedMessage: true,
  45s       code: 'ERR_ASSERTION',
  45s       actual: 'true',
  45s       expected: 'false',
  45s       operator: 'strictEqual'
  45s     }
  45s

  46s not ok 261 parallel/test-cli-permission-deny-fs
  46s   ---
  46s   duration_ms: 911.79900
  46s   severity: fail
  46s   exitcode: 1
  46s   stack: |-
  46s     node:assert:126
  46s       throw new AssertionError(obj);
  46s       ^
  46s
  46s     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  46s     + actual - expected
  46s
  46s     + 'true'
  46s     - 'false'
  46s         at Object.<anonymous> (/tmp/autopkgtest-lxc.voqp2vqz/downtmp/build.4lW/src/test/parallel/test-cli-permission-deny-fs.js:45:10)
  46s         at Module._compile (node:internal/modules/cjs/loader:1358:14)
  46s         at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
  46s         at Module.load (node:internal/modules/cjs/loader:1208:32)
  46s         at Module._load (node:internal/modules/cjs/loader:1024:12)
  46s         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
  46s         at node:internal/main/run_main_module:28:49 {
  46s       generatedMessage: true,
  46s       code: 'ERR_ASSERTION',
  46s       actual: 'true',
  46s       expected: 'false',
  46s       operator: 'strictEqual'
  46s     }
  46s
  46s     Node.js v20.15.1
  46s   ...


Not sure what happened

Also, please add strace to test dependencies to also run strace tests
  68s ok 2483 parallel/test-strace-openat-openssl # skip missing strace

Note: to make it work you probably need the following patches:

diff -Nru nodejs-20.15.1+dfsg/debian/patches/ubuntu-openssl-fix-strace-openat-test.patch nodejs-20.15.1+dfsg/debian/patches/ubuntu-openssl-fix-strace-openat-test.patch
--- nodejs-20.15.1+dfsg/debian/patches/ubuntu-openssl-fix-strace-openat-test.patch	1970-01-01 00:00:00.000000000 +0000
+++ nodejs-20.15.1+dfsg/debian/patches/ubuntu-openssl-fix-strace-openat-test.patch	2024-06-28 12:25:37.000000000 +0000
@@ -0,0 +1,36 @@
Index: nodejs-20.13.1+dfsg/test/parallel/test-strace-openat-openssl.js
===================================================================
--- nodejs-20.13.1+dfsg.orig/test/parallel/test-strace-openat-openssl.js
+++ nodejs-20.13.1+dfsg/test/parallel/test-strace-openat-openssl.js
@@ -5,6 +5,7 @@ const { spawn, spawnSync } = require('no
  const { createInterface } = require('node:readline');
  const assert = require('node:assert');
  
+process.env.OPENSSL_CONF="/usr/lib/ssl/openssl.cnf"
  if (!common.hasCrypto)
    common.skip('missing crypto');
  if (!common.isLinux)
@@ -17,7 +18,7 @@ if (spawnSync('strace').error !== undefi
  
  {
    const allowedOpenCalls = new Set([
-    '/etc/ssl/openssl.cnf',
+    '/usr/lib/ssl/openssl.cnf',
    ]);
    const strace = spawn('strace', [
      '-f', '-ff',
@@ -42,6 +43,14 @@ if (spawnSync('strace').error !== undefi
      if (file.match(/\/proc\/.+/) !== null) {
        return;
      }
+    // skip zoneinfo
+    if (file.match(/zoneinfo64.res/) !== null) {
+      return;
+    }
+    // skip /dev/z90crypt, new in openssl 3.2*
+    if (file.match(/z90crypt/) !== null) {
+      return;
+    }
  
      assert(allowedOpenCalls.delete(file), `${file} is not in the list of allowed openat calls`);
    });

diff -Nru nodejs-20.15.1+dfsg/debian/tests/control nodejs-20.15.1+dfsg/debian/tests/control
--- nodejs-20.15.1+dfsg/debian/tests/control	2024-07-09 08:02:04.000000000 +0000
+++ nodejs-20.15.1+dfsg/debian/tests/control	2024-07-09 21:53:29.000000000 +0000
@@ -1,2 +1,2 @@
  Test-Command: ./debian/rules override_dh_auto_test-arch
-Depends: @, ca-certificates, python3, procps, curl, build-essential
+Depends: @, ca-certificates, python3, procps, curl, build-essential, tzdata-icu, strace


thanks,

Gianfranco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20240718/3d0382ab/attachment.sig>