[Pkg-javascript-devel] Bug#1074059: bookworm-pu: package nodejs/18.19.0+dfsg-6~deb12u2

[Adrian Bunk]

Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org at packages.debian.org
Usertags: pu
X-Debbugs-Cc: security at debian.org, Debian Javascript Maintainers <pkg-javascript-devel at alioth-lists.debian.net>, Jérémy Lal <kapouer at melix.org>

This upload aims at fixing the failing build of 18.19.0+dfsg-6~deb12u1
on mips64el and mipsel.

The changes are:
- copy mips/flaky_tests.patch with mips64el skip/flaky from 18.19.1+dfsg-6
- add test-http2-forget-closed-streams to flaky on mips64el
- skip two failing tests on mipsel

This is based on reading the output of the build failures last night
with some testing done on amd64.

I am kinda optimistic that it will work and even in the worst case
it shouldn't make anything worse, but there is not enough time to
properly verify it on MIPS before the point release deadline.

I've just uploaded it, feel free to accept or reject it.
-------------- next part --------------
diffstat for nodejs-18.19.0+dfsg nodejs-18.19.0+dfsg

 changelog                      |    7 +++++++
 patches/mips/flaky_tests.patch |   26 ++++++++++++++++++++++++++
 patches/series                 |    1 +
 3 files changed, 34 insertions(+)

diff -Nru nodejs-18.19.0+dfsg/debian/changelog nodejs-18.19.0+dfsg/debian/changelog
--- nodejs-18.19.0+dfsg/debian/changelog	2023-12-20 19:07:36.000000000 +0200
+++ nodejs-18.19.0+dfsg/debian/changelog	2024-06-22 15:21:29.000000000 +0300
@@ -1,3 +1,10 @@
+nodejs (18.19.0+dfsg-6~deb12u2) bookworm; urgency=medium
+
+  * Non-maintainer upload.
+  * Skip failing tests on MIPS.
+
+ -- Adrian Bunk <bunk at debian.org>  Sat, 22 Jun 2024 15:21:29 +0300
+
 nodejs (18.19.0+dfsg-6~deb12u1) bookworm-security; urgency=medium
 
   * Upstream update.
diff -Nru nodejs-18.19.0+dfsg/debian/patches/mips/flaky_tests.patch nodejs-18.19.0+dfsg/debian/patches/mips/flaky_tests.patch
--- nodejs-18.19.0+dfsg/debian/patches/mips/flaky_tests.patch	1970-01-01 02:00:00.000000000 +0200
+++ nodejs-18.19.0+dfsg/debian/patches/mips/flaky_tests.patch	2024-06-22 15:21:29.000000000 +0300
@@ -0,0 +1,26 @@
+Description: some tests fail on mips64el and mipsel
+ That architecture support improves over time - node 20.x branch has better support for mips64el
+ Meanwhile, let those tests fail.
+Forwarded: not-needed
+--- nodejs-18.19.0+dfsg.orig/test/parallel/parallel.status
++++ nodejs-18.19.0+dfsg/test/parallel/parallel.status
+@@ -97,6 +97,19 @@ test-wasm-web-api: SKIP
+ [$arch==mips64el]
+ # the debug flag is for hacking v8 internals
+ test-debug-args: PASS,FLAKY
++test-cli-node-options: SKIP
++test-crypto-sign-verify: PASS,FLAKY
++test-freeze-intrinsics: PASS,FLAKY
++test-http2-forget-closed-streams: PASS,FLAKY
++test-tls-root-certificates: PASS,FLAKY
++test-vm-global-non-writable-properties: PASS,FLAKY
++test-vm-global-setter: PASS,FLAKY
++test-vm-module-synthetic: PASS,FLAKY
++test-vm-strict-assign: PASS,FLAKY
++
++[$arch==mipsel]
++test-cli-node-options: SKIP
++test-debugger-extract-function-name: SKIP
+ 
+ [$system==solaris] # Also applies to SmartOS
+ # https://github.com/nodejs/node/issues/43457
diff -Nru nodejs-18.19.0+dfsg/debian/patches/series nodejs-18.19.0+dfsg/debian/patches/series
--- nodejs-18.19.0+dfsg/debian/patches/series	2023-12-20 18:54:47.000000000 +0200
+++ nodejs-18.19.0+dfsg/debian/patches/series	2024-06-22 15:21:29.000000000 +0300
@@ -26,3 +26,4 @@
 build/disable_sea_dfsg_postject.patch
 build/test_runner_escape_path.patch
 build/test_dns_resolveany_bad_ancount.patch
+mips/flaky_tests.patch