[Pkg-javascript-devel] Bug#1068750: moment-timezone.js: FTBFS everywhere

[Jérémy Lal]

On Tue, 30 Apr 2024 22:41:45 +0100 Martina Ferrari <tina at tina.pm> wrote:
> Hi Santiago,
>
> On 30/04/2024 14:01, Santiago Vila wrote:
>
> >> It fails to build if tzdata is updated, but it never stops working. It
> >> just needs to be updated as often as tzdata is. But if you have a
> >> suggestion to make this more automatic, I would love to hear it..
> >
> > Sorry, I still don't get it.
> >
> > Why does the package build needs to fail if tzdata is updated?
>
> > What happens if we allow the package to be built anyway?
> > (as in the attached patch).
> > Would the resulting package be broken in any way?
>
> It works, but then there is no way to embed the (effective) tzdata
> version into the moment-timezone.js version, so you could have identical
> source packages producing binaries with the same version and different
> contents, and no way to depend on it.
> Plus, it almost always fails to
> build anyway, because many of the tests need to be adjusted when tzdata
> changes.

Indeed, a part of the test suite can be generated during build.
So it's actually possible to rebuild this package without manual
intervention of its maintainer,
whenever tzdata is updated.
That's what I pushed in the salsa repository.

I think it's a use case for adding
Static-Built-Using: tzdata-legacy

to debian/control ???

> The (better) alternative would be to make it always use a fixed tzdata
> version, but then tzdata migrations will be blocked each time until I
> upload a new version.

I skipped the generated tests for autopkgtests, and kept them only during
build time to avoid the previous solution, which was to embed the tests/*
in the binary package, taking way too much space for that matter.
If running the generated tests during autopkgtests is important, it should
be run in the built source package instead.

Jérémy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20240916/2f26562a/attachment.htm>