[Pkg-javascript-devel] Bug#1123663: node-convert-source-map: please make the build reproducible

[Chris Lamb]

Source: node-convert-source-map
Version: 1.9.0+~1.5.2-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: nocheck
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
node-convert-source-map could not be built reproducibly.

This is because the package differed depending on whether the tests
were run or not; the installation of the comment-to-json.js was skipped
in the latter case. I couldn't see an immediate reason why we should
skip installation if nocheck specified (the file doesn't differ), so
I've attached a patch that installs it regardless.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2025-12-19 08:10:06.097314942 -0800
--- b/debian/rules	2025-12-19 08:20:34.105146187 -0800
@@ -7,13 +7,6 @@
 %:
 	dh $@
 
-override_dh_installexamples:
-ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)))
-	dh_installexamples
+execute_after_dh_installexamples:
 	find $(CURDIR)/debian/node-convert-source-map/usr/share/doc/node-convert-source-map/examples/ -name '*.js' -exec \
 		sed -i "s,require\s*[(]\s*'[.][.][^']*'\s*[)],require('convert-source-map'),g" {} \;
-else
-	@echo '**********************************************************'
-	@echo 'Skip example                                              '
-	@echo '**********************************************************'
-endif