[Pkg-javascript-devel] Bug#1106429: node-finalhandler: FTBFS: test "should encode bad pathname characters" fails

[Santiago Vila]

Package: src:node-finalhandler
Version: 1.2.0+~1.1.1-2
Severity: serious
Tags: ftbfs trixie sid

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

--------------------------------------------------------------------------------
[...]
 debian/rules clean
dh clean
   dh_auto_clean --buildsystem=nodejs
	rm -rf ./node_modules/.cache ./.nyc_output
	rm -rf types-finalhandler/node_modules/.cache types-finalhandler/.nyc_output
rm ./node_modules/.cache
rm types-finalhandler/node_modules/.cache
rm ./node_modules/.cache
unlink node_modules/@types/finalhandler
   dh_clean
 debian/rules binary
dh binary
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_configure --buildsystem=nodejs
Link node_modules/@types/finalhandler -> ../../types-finalhandler
   dh_auto_build --buildsystem=nodejs
No build command found, searching known files
No build command found, searching known files
   dh_auto_test --buildsystem=nodejs
	ln -s ../. node_modules/finalhandler
	/bin/sh -ex debian/tests/pkg-js/test
+ mocha --reporter spec --bail --check-leaks test/


  finalhandler(req, res)
    headers
      undefined should ignore err.headers without status code
      undefined should ignore err.headers with invalid res.status
      undefined should ignore err.headers with invalid res.statusCode
      undefined should include err.headers with err.status
      undefined should include err.headers with err.statusCode
      undefined should ignore err.headers when not an object
    status code
      undefined should 404 on no error
      undefined should 500 on error
      undefined should use err.statusCode
      undefined should ignore non-error err.statusCode code
      undefined should ignore non-numeric err.statusCode
      undefined should use err.status
      undefined should use err.status over err.statusCode
      undefined should set status to 500 when err.status < 400
      undefined should set status to 500 when err.status > 599
      undefined should use err.statusCode over invalid err.status
      undefined should ignore non-error err.status code
      undefined should ignore non-numeric err.status
    status message
      undefined should be "Not Found" on no error
      undefined should be "Internal Server Error" on error
      undefined should be "Bad Request" when err.statusCode = 400
      undefined should reset existing res.statusMessage
    404 response
      undefined should include method and pathname
      undefined should escape method and pathname characters
      1) should encode bad pathname characters


  24 passing (74ms)
  1 failing

  1) finalhandler(req, res)
       404 response
         should encode bad pathname characters:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

400 !== 404

      + expected - actual

      -400
      +404
      
      at IncomingMessage.onend (test/support/utils.js:79:20)
      at IncomingMessage.emit (node:events:536:35)
      at endReadableNT (node:internal/streams/readable:1698:12)
      at process.processTicksAndRejections (node:internal/process/task_queues:82:21)



dh_auto_test: error: /bin/sh -ex debian/tests/pkg-js/test returned exit code 1
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202505/

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and add an affects on src:node-finalhandler, so that this is still
visible in the BTS web page for this package.

Thanks.