[Pkg-javascript-devel] node-tsc-alias_1.8.16-1_amd64.changes REJECTED

[Joe Nahmias]

Hello,

On Fri, May 01, 2026 at 01:00:07PM +0000, Reinhard Tartler wrote:
> 
> Thanks for your diligence while working on this package. I've had a look
> through the source, and while it's mostly there, I have to reject it for
> now because of inaccuracies in `debian/copyright` and missing metadata.
> 
> ### Critical Issues (Blockers)
> 
> 1.  **Failure to Reproduce Copyright Notices Verbatim**:
>     The Expat license requires that "The above copyright notice and this
>     permission notice shall be included in all copies or substantial
>     portions of the Software." In `debian/copyright`, the upstream
>     notice has been modified to "Juste Méthode B. <cervotechit at gmail.com>".
>     While this might be an attempt to identify the author's legal name,
>     the license mandates verbatim reproduction of the notice found in
>     the source: `Copyright (c) 2018 Justkey`. Please update the stanza
>     to match the upstream `LICENSE` file exactly.

fixed.

> 2.  **Incorrect Copyright Years**:
>     The upstream copyright year in `debian/copyright` is listed as 2026,
>     but the source code's `LICENSE` file is dated 2018. The years in
>     `debian/copyright` must accurately reflect the notices in the
>     source.

fixed

> 3.  **Missing Copyright for Test Projects**:
>     `projects/project24/package.json` identifies a different author:
>     `"author": "Dmitry Kirilyuk <gk.joker at gmail.com>"`. This file is not
>     covered by the current `debian/copyright` stanzas. Please add a
>     specific stanza for these files, again ensuring you reproduce the
>     copyright notice as it appears in the source.

added, but there's no copyright notice per se. I infered the copyright date
from the git commit date which added the file.

> ### Required Fixes
> 
> -   Update `debian/copyright` to verbatim match the upstream copyright
>     notices and years.
done.

> -   Add a stanza for `projects/project24/*` to credit Dmitry Kirilyuk.
done, as noted above.

> -   Add `Priority: optional` to the `Source` stanza in `debian/control`
>     to comply with Debian Policy 2.5.

My understanding of the current policy is that this is incorrect. Quoting:

    Starting with dpkg version 1.22.13, the Priority of a binary package
    is set to optional unless specified otherwise in the source or its
    binary stanza in the source package template control file. Therefore,
    explicitly specifying Priority as optional may be omitted.

> -rt
> 
> Further information may be found at:
>    https://dfsg-new-queue.debian.org/reviews/node-tsc-alias
> 
> Regards, Reinhard Tartler
> Member of the DFSG, Licensing & New Packages Team
> 
> ===
> 
> Please feel free to respond to this email if you don't understand why
> your files were rejected, or if you upload new files which address our
> concerns.

reuploaded

Much appreciate your review!
--Joe