[Pkg-javascript-devel] Bug#1153497: node-object-key: drop unused node-assert build dependency

[刘子曦]

Source: node-object-key
Version: 0.2.0-5
Severity: minor
Tags: patch

Dear Maintainer,

Please consider removing node-assert <!nocheck> from Build-Depends.

test/ok-test.js uses require("assert"), which resolves to the Node.js
built-in module in the Mocha test environment. The implementation uses
lodash. The separately packaged assert polyfill is not used by this
build/test entry point.

I checked this on 2026-11-09 using two fresh, independent amd64 Debian sid
containers, one with the original control file and one with the attached
one-line patch. Both used the same official Debian base image and the
same current sid APT indexes. Source archive checksums were checked
against the signed sid source index. This was a Docker container build,
not an sbuild run.

Each build installed build dependencies from its own control file and ran:
  DEB_BUILD_OPTIONS=parallel=2 dpkg-buildpackage -us -uc -b

No nocheck/nodoc profile or option was enabled. Both binary builds
succeeded and all 12 Mocha tests ran and passed in each build.
The patched environment did not have node-assert installed; Node.js
was still installed (v24.22.2). Common installed packages had the
same versions and architectures in both builds.

The resulting .deb files are byte-identical (SHA256 matches).

The patch changes only this Build-Depends entry. The test source,
test entry point, packaging sequence and runtime dependencies are kept.
This validation covers one baseline and one patched amd64 build; I have
not checked other architectures or combined dependency removals.

Attached are the patch and both complete dpkg-buildpackage logs.


                        Thank you,

                              Zixi Liu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20261109/c9016861/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-unused-node-assert-build-dependency.patch
Type: application/octet-stream
Size: 261 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20261109/c9016861/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: baseline-build.log
Type: application/octet-stream
Size: 2508 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20261109/c9016861/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patched-build.log
Type: application/octet-stream
Size: 2508 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20261109/c9016861/attachment-0002.obj>