[Pkg-javascript-devel] Bug#1153787: node-on-finished: drop unused node-should build dependency

[刘子曦]

Source: node-on-finished
Version: 2.4.1+~1.1.1-2
Severity: minor
Tags: patch

Dear Maintainer,

Please consider removing node-should <!nocheck> from Build-Depends.

The main tests and the embedded ee-first tests use the Node.js built-in
assert module. They do not import should.

I tested the original source and a version with only this Build-Depends
entry removed in two independent clean local Debian sid Docker containers
(amd64), using the same freshly updated signed APT indexes and the same
128-package base. Build dependencies were installed from each variant's
control file; no tests were disabled and no dependencies were added by hand.

Both builds succeeded, with 8+44 tests passing in each build. The patched
build did not have node-should installed. Installed package counts were
267 and 266; the omitted packages were node-should. No new packages
appeared and the versions/architectures of common packages were unchanged.
The generated node-on-finished_2.4.1+~1.1.1-2_all.deb files were
byte-for-byte identical:
SHA256 84b53765e7d961ec7584def80ab90af05839ce0f79cff80f2ff3c5963da6aa19

The patch changes only Build-Depends; binary Depends are unchanged. This
validation covers the default profiles on amd64, one build per variant;
I did not run a separate autopkgtest or test other architectures.

I checked the current and archived source-package BTS reports and open
Salsa merge requests on 2026-11-12 and did not find a duplicate.

Attached are the patch, both complete build logs and a verification summary.

Regards,
Zixi Liu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20261112/4b505a69/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-unused-node-should-build-dependency.patch
Type: application/octet-stream
Size: 323 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20261112/4b505a69/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: baseline-build.log
Type: application/octet-stream
Size: 6898 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20261112/4b505a69/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patched-build.log
Type: application/octet-stream
Size: 6898 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20261112/4b505a69/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: verification.json
Type: application/json
Size: 1084 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20261112/4b505a69/attachment.json>