[Pkg-julia-devel] Bug#765420: Bug#765420: Please, use libjs-modernizr instead of linking to an external website

[David Prévot]

Control: tags -1 + patch fixed-upstream
Control: clone -1 -2
Control: retitle -2 Please, let dh_sphinxdoc use fonts-font-awesome and libjs-modernizr dependencies

Hi Sébastien,

On Sat, Nov 15, 2014 at 03:33:07PM -0400, David Prévot wrote:
> Le 15/11/2014 12:38, Sébastien Villemot a écrit :
> > Le mardi 14 octobre 2014 à 18:27 -0400, David Prévot a écrit :
> >> Package: python-sphinx-rtd-theme
> 
> >> Please, patch sphinx_rtd_theme/layout.html to use the JavaScript
> >> provided by libjs-modernizr instead of making all documentation fetch a 
> >> script from the web.

Actually, upstream already fixed that internally.

> > If I understand correctly, implementing that change means that reverse
> > dependencies of python-sphinx-rtd-theme will need to declare a
> > dependency on libjs-modernizr.

> I guess it should be a two step thing:
> 
> First, python-sphinx-rtd-theme should depend on libjs-modernizr, and
> symlink those JavaScript files from where they belong

The attached patch series addresses this initial concerns.

> Then, for Debian packages building such documentation, dh_sphinxdoc
> should replace the embedded copy by a symlink to the file provided by
> libjs-modernizr, and add the proper dependency in ${sphinxdoc:Depends}.

Bug cloned for this second part (I’ve no dh_sphinxdoc knowledge yet to
share for this one). The fonts from fonts-font-awesome should also be
replaced by a proper symlink in Debian packages.

Regards

David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-local-modernizr.patch
Type: text/x-diff
Size: 18724 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-julia-devel/attachments/20150403/2ece7bde/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-missing-source-for-sphinx_rtd_theme-static-js-mo.patch
Type: text/x-diff
Size: 52232 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-julia-devel/attachments/20150403/2ece7bde/attachment-0005.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Use-libjs-modernizr-instead-of-the-internal-copy.patch
Type: text/x-diff
Size: 3091 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-julia-devel/attachments/20150403/2ece7bde/attachment-0006.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Wrap-and-sort.patch
Type: text/x-diff
Size: 2311 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-julia-devel/attachments/20150403/2ece7bde/attachment-0007.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-julia-devel/attachments/20150403/2ece7bde/attachment-0001.sig>