[Pkg-kbd-devel] Bug#386838: console-setup: non-Latin handling for cs seems wrong

[Colin Watson]

Package: console-setup
Version: 1.7
Severity: normal
Tags: patch

Part of debian/config.proto looks like this:

                case "$layout" in
                    # TODO: make s.t. to not forget to update this list
                    # Don't forget to update also the list in kbdcompiler
                    am|ara|ben|bd|bg|bt|by|cs|deva|ge|gh|gr|guj|guru|il|in|ir|iku|jp|kan|kh|la|lao|lk|mk|mm|mn|mv|mal|ori|pk|ru|scc|sy|syr|tel|th|tj|tam|ua|uz)
                        latin=no
                        real_layout=us,$layout
                        ;;
                    cs)
                        case "$variant" in
                            latin*)
                                latin=yes
                                real_layout=$layout
                                ;;
                            *)
                                latin=no
                                real_layout=cs,cs
                                ;;
                        esac
                        ;;
                    *)
                        latin=yes
                        real_layout=$layout
                        ;;
                esac

Having cs in the first branch of the case statement looks wrong, because
that means that the second branch will never be taken. The attached
patch corrects this. (You might also want to remove the corresponding
entry from $nonlatin in Keyboard/kbdcompiler, but the code there is
different so it wasn't immediately necessary.)

Thanks,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]
-------------- next part --------------
--- console-setup-1.7.orig/debian/config.proto	2006-07-22 21:05:55.000000000 +0100
+++ console-setup-1.7/debian/config.proto	2006-09-10 12:05:27.000000000 +0100
@@ -1145,7 +1145,7 @@
 		case "$layout" in
 		    # TODO: make s.t. to not forget to update this list
                     # Don't forget to update also the list in kbdcompiler
-		    am|ara|ben|bd|bg|bt|by|cs|deva|ge|gh|gr|guj|guru|il|in|ir|iku|jp|kan|kh|la|lao|lk|mk|mm|mn|mv|mal|ori|pk|ru|scc|sy|syr|tel|th|tj|tam|ua|uz)
+		    am|ara|ben|bd|bg|bt|by|deva|ge|gh|gr|guj|guru|il|in|ir|iku|jp|kan|kh|la|lao|lk|mk|mm|mn|mv|mal|ori|pk|ru|scc|sy|syr|tel|th|tj|tam|ua|uz)
 			latin=no
 			real_layout=us,$layout
 			;;