[Pkg-kbd-devel] Bug#542225: kbd: Incorrect provides and dependencies in init.d script

[Petter Reinholdtsen]

Package:  kbd
Version:  1.14.1-3
Severity: important
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-provides incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The provides should be unique and
preferably the name of the script.  The current one conflict with the
console-screen script in the console-tools package.  The $local_fs
dependency is redundant as $remote_fs implies $local_fs.  To make sure
the ordering of console-screen.kbd.sh, console-screen.sh and
console-setup is well defined when all these packages are installed, I
suggest stating that console-screen should run after
console-screen.kbd.  And to avoid surprises, I list all scripts
currently depending on console-screen in the archive as script that
should run after console-screen.kbd.sh.  This will make sure these
scripts are started in this order if all three packages are installed:
console-screen.kbd, console-screen.sh, console-setup.

I notice this issue was discussed in #483607.  I believe the
X-Start-Before: header in this patch solve the problems raised there,
after checking all init.d scripts in the archive.  Another approach
would be to decide on a new virtual facility name to use for this kind
of service (like $syslog).

<URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Without it, the script will fail
to install if another script providing the same words already is
installed.

diff -ru kbd-1.15/debian/console-screen.kbd.sh kbd-1.15-pere/debian/console-screen.kbd.sh
--- kbd-1.15/debian/console-screen.kbd.sh       2009-08-18 16:22:35.000000000 +0200
+++ kbd-1.15-pere/debian/console-screen.kbd.sh  2009-08-18 16:25:41.000000000 +0200
@@ -1,8 +1,9 @@
 #!/bin/sh
 ### BEGIN INIT INFO
-# Provides:          console-screen
-# Required-Start:    $local_fs $remote_fs
+# Provides:          console-screen.kbd
+# Required-Start:    $remote_fs
 # Required-Stop:
+# X-Start-Before:    console-screen console-setup xdm gdm kdm nodm wdm
 # Default-Start:     S
 # Default-Stop:
 # X-Interactive:     true

Happy hacking,
-- 
Petter Reinholdtsen